rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-15 01:12:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't push latest tags on release branch

Browse Source 
before this change we pushed latest tag both on main
and on release. This could lead to akward situations when you
start using some freshly merged to main feature and then the
release happens and you start getting older image. It's possible
to bump into this both locally and in cloud CI.
The proposal is to only push latest on main. This is unlikely to
cause issues because now if someone merges after the release
latest is agin at main. However, the tag is more consistent
and not depend on timing of merges
This commit is contained in:
Nikita Kalyanov
2023-05-24 18:55:47 +03:00
parent afc48e2cd9
commit 82174e359a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/build_and_test.yml vendored
View File

@@ -872,7 +872,7 @@ jobs:
- name: Add latest tag to images
if: |
(github.ref_name == 'main' || github.ref_name == 'release') &&
github.ref_name == 'main' &&
github.event_name != 'workflow_dispatch'
run: |
crane tag 369495373322.dkr.ecr.eu-central-1.amazonaws.com/neon:${{needs.tag.outputs.build-tag}} latest
@@ -884,7 +884,7 @@ jobs:
- name: Push images to production ECR
if: |
(github.ref_name == 'main' || github.ref_name == 'release') &&
github.ref_name == 'main' &&
github.event_name != 'workflow_dispatch'
run: |
crane copy 369495373322.dkr.ecr.eu-central-1.amazonaws.com/neon:${{needs.tag.outputs.build-tag}} 093970136003.dkr.ecr.eu-central-1.amazonaws.com/neon:latest
@@ -907,7 +907,7 @@ jobs:
- name: Push latest tags to Docker Hub
if: |
(github.ref_name == 'main' || github.ref_name == 'release') &&
github.ref_name == 'main' &&
github.event_name != 'workflow_dispatch'
run: |
crane tag neondatabase/neon:${{needs.tag.outputs.build-tag}} latest