rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-07 13:32:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flaky test_metrics_collection.py

Browse Source 
Only check that all metrics are present on the first request,
because pageserver doesn't send unchanged metrics.
This commit is contained in:
Anastasia Lubennikova
2022-12-21 18:31:52 +02:00
parent 63eb87bde3
commit 8544c59329
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test_runner/regress/test_metric_collection.py
View File

@@ -22,6 +22,7 @@ def httpserver_listen_address(port_distributor: PortDistributor):
num_metrics_received = 0
remote_uploaded = 0
first_request = True
#
@@ -46,7 +47,12 @@ def metrics_handler(request: Request) -> Response:
for event in events:
assert checks.pop(event["metric"])(event["value"]), f"{event['metric']} isn't valid"
assert not checks, f"{' '.join(checks.keys())} wasn't/weren't received"
global first_request
# check that all checks were sent
# but only on the first request, because we don't send non-changed metrics
if first_request:
assert not checks, f"{' '.join(checks.keys())} wasn't/weren't received"
first_request = False
global num_metrics_received
num_metrics_received += 1