remove resolved todos

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
This commit is contained in:
Yuchen Liang
2024-11-25 05:42:16 +00:00
parent d4ebd5ccd3
commit 8a37f412c2
2 changed files with 0 additions and 3 deletions

View File

@@ -235,8 +235,6 @@ async fn download_object<'a>(
Ok(chunk) => chunk,
Err(e) => return Err(e),
};
// TODO(yuchen): might have performance issue when using borrowed version?
// Problem: input is Bytes, does not satisify IO alignment requirement.
buffered.write_buffered_borrowed(&chunk, ctx).await?;
}
let inner = buffered.flush_and_into_inner(ctx).await?;

View File

@@ -17,7 +17,6 @@ pub struct FlushHandle<Buf, W> {
pub(super) maybe_flushed: Option<FullSlice<Buf>>,
}
// TODO(yuchen): special actions in drop to clean up the join handle?
pub struct FlushHandleInner<Buf, W> {
/// A bi-directional channel that sends (buffer, offset) for writes,
/// and receives recyled buffer.