cleanups & self-review

libs/remote_storage/tests/common/mod.rs

@@ -13,7 +13,7 @@ use tokio::task::JoinSet;
 use tokio_util::sync::CancellationToken;
 use tracing::{debug, error, info};
 
-static LOGGING_DONE: OnceCell<()> = OnceCell::new();
+static LOGGING_DONE: OnceCell<utils::logging::FlushGuard> = OnceCell::new();
 
 pub(crate) fn upload_stream(
     content: std::borrow::Cow<'static, [u8]>,
@@ -205,11 +205,11 @@ pub(crate) async fn upload_remote_data(
 
 pub(crate) fn ensure_logging_ready() {
     LOGGING_DONE.get_or_init(|| {
-        let _ = utils::logging::init(
+        utils::logging::init(
             utils::logging::LogFormat::Test,
             utils::logging::TracingErrorLayerEnablement::Disabled,
             utils::logging::Output::Stdout,
         )
-        .expect("logging init failed");
+        .expect("logging init failed")
     });
 }

libs/utils/src/lib.rs

@@ -31,7 +31,6 @@ pub mod id;
 pub mod shard;
 
 mod hex;
-
 pub use hex::Hex;
 
 // http endpoint utils