rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-16 01:42:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

add comment

Browse Source
This commit is contained in:
Christian Schwarz
2024-02-01 17:26:39 +00:00
parent d9f89f828d
commit 91cec9ba48
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pageserver/src/walredo.rs
View File

@@ -204,6 +204,18 @@ impl PostgresRedoManager {
pub(crate) fn maybe_quiesce(&self, idle_timeout: Duration) {
if let Ok(g) = self.last_successful_redo_at.try_lock() {
if let Some(last_successful_redo_at) = *g {
// Kill the walredo process if
// - it has been unused for `idle_timeout`
// - it has been used, but, without success.
// The former is just good housekeeping.
// The latter adds robustness for the case where something is wrong
// with the walredo process.
//
// Note that we don't want to kill the process immediately on each redo failure.
// The reason is that the redo failure could be caused by corrupted or malicious data.
// We don't want to get into a kill-respawn loop in that case.
// So, we piggy-back on the quiescing mechanism,
// resulting in a max kill-respawn frequency of `1/idle_timeout`.
if last_successful_redo_at.elapsed() >= idle_timeout {
drop(g);
let mut guard = self.redo_process.write().unwrap();