rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-15 01:12:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prohibit insertion fo dulicated layers in layer map

Browse Source
This commit is contained in:
Konstantin Knizhnik
2023-03-21 19:24:25 +02:00
parent c2731e17a9
commit 95dd5c71bf
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pageserver/src/tenant/layer_map/historic_layer_coverage.rs
View File

@@ -418,6 +418,12 @@ impl<Value: Clone> BufferedHistoricLayerCoverage<Value> {
}
pub fn insert(&mut self, layer_key: LayerKey, value: Value) {
// layer duplicates are not allowed
assert!(!self.layers.contains_key(&layer_key));
self.buffer.insert(layer_key, Some(value));
}
pub fn replace_existed(&mut self, layer_key: LayerKey, value: Value) {
self.buffer.insert(layer_key, Some(value));
}
@@ -472,7 +478,7 @@ impl<Value: Clone> BufferedHistoricLayerCoverage<Value> {
}
None => Replacement::NotFound,
Some(_existing) => {
self.insert(layer_key.to_owned(), new);
self.replace_existed(layer_key.to_owned(), new);
Replacement::Replaced { in_buffered }
}
}
@@ -490,12 +496,10 @@ impl<Value: Clone> BufferedHistoricLayerCoverage<Value> {
self.buffer.retain(|layer_key, layer| {
match layer {
Some(l) => {
// There should not be duplicate layers
assert!(self.layers.insert(layer_key.clone(), l.clone()).is_none());
self.layers.insert(layer_key.clone(), l.clone());
}
None => {
// layer is present in the tree
assert!(self.layers.remove(layer_key).is_some());
self.layers.remove(layer_key);
}
};
false