rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-14 17:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address simple review comments

Browse Source
This commit is contained in:
Arpad Müller
2025-01-25 03:33:21 +01:00
parent 7ec08ee805
commit 986db002cd
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
storage_controller/src/safekeeper_client.rs
View File

@@ -1,3 +1,4 @@
use crate::metrics::PageserverRequestLabelGroup;
use safekeeper_api::models::{TimelineCreateRequest, TimelineStatus};
use safekeeper_client::mgmt_api::{Client, Result};
use utils::{
@@ -17,7 +18,7 @@ pub(crate) struct SafekeeperClient {
macro_rules! measured_request {
($name:literal, $method:expr, $node_id: expr, $invoke:expr) => {{
let labels = crate::metrics::PageserverRequestLabelGroup {
let labels = PageserverRequestLabelGroup {
pageserver_id: $node_id,
path: $name,
method: $method,

1
storage_controller/src/service.rs
View File

@@ -3571,7 +3571,6 @@ impl Service {
models::TimelineCreateRequestMode::Bootstrap { .. } => timeline_info.last_record_lsn,
models::TimelineCreateRequestMode::Branch { .. } => timeline_info.last_record_lsn,
models::TimelineCreateRequestMode::ImportPgdata { .. } => {
// Can't do return Err because of async block, must do ? plus unreachable!()
return Err(ApiError::InternalServerError(anyhow!(
"import pgdata doesn't specify the start lsn, aborting creation on safekeepers"
)))?;