rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-15 17:32:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(storage-scrubber): handle race of index part download

Browse Source 
Signed-off-by: Alex Chi Z <chi@neon.tech>
This commit is contained in:
Alex Chi Z
2024-09-19 15:53:51 -04:00
parent 1708743e78
commit 9880653e11
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
storage_scrubber/src/checks.rs
View File

@@ -478,9 +478,21 @@ pub(crate) async fn list_timeline_blobs(
if let Some(index_part_object_key) = index_part_object.as_ref() {
let index_part_bytes =
download_object_with_retries(remote_client, &index_part_object_key.key)
match download_object_with_retries(remote_client, &index_part_object_key.key)
.await
.context("index_part.json download")?;
.context("index_part.json download")
{
Ok(index_part_bytes) => index_part_bytes,
Err(e) => {
// It is possible that the branch gets deleted in-between we list the objects and we download the index part file.
errors.push(format!("failed to download : {e}"));
return Ok(RemoteTimelineBlobData {
blob_data: BlobDataParseResult::Incorrect { errors, s3_layers },
unused_index_keys: index_part_keys,
unknown_keys,
});
}
};
match serde_json::from_slice(&index_part_bytes) {
Ok(index_part) => {