rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-07 05:22:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update TODO comment now that we handle relation drops

Browse Source 
Commit ced338fd20 neglected this comment. In the passing, also move around
the comments explaining the two kinds of thing we store per page.
This commit is contained in:
Heikki Linnakangas
2021-06-30 12:50:32 +03:00
parent d4329887b3
commit 9c856ecf43
2 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
pageserver/src/object_repository.rs
View File

@@ -930,16 +930,19 @@ impl<'a> ObjectHistory<'a> {
/// 1. Ready-made images of the block
/// 2. WAL records, to be applied on top of the "previous" entry
///
/// Some WAL records will initialize the page from scratch. For such records,
/// the 'will_init' flag is set. They don't need the previous page image before
/// applying. The 'will_init' flag is set for records containing a full-page image,
/// and for records with the BKPBLOCK_WILL_INIT flag. These differ from PageImages
/// stored directly in the cache entry in that you still need to run the WAL redo
/// routine to generate the page image.
///
#[derive(Debug, Clone, Serialize, Deserialize)]
enum PageEntry {
/// Ready-made image of the block
Page(Bytes),
/// WAL record, to be applied on top of the "previous" entry
///
/// Some WAL records will initialize the page from scratch. For such records,
/// the 'will_init' flag is set. They don't need the previous page image before
/// applying. The 'will_init' flag is set for records containing a full-page image,
/// and for records with the BKPBLOCK_WILL_INIT flag. These differ from Page images
/// stored directly in the repository in that you still need to run the WAL redo
/// routine to generate the page image.
WALRecord(WALRecord),
}
@@ -952,12 +955,6 @@ pub enum RelationSizeEntry {
Size(u32),
/// Tombstone for a dropped relation.
//
// TODO: Not used. Currently, we never drop relations. The parsing
// of relation drops in COMMIT/ABORT records has not been
// implemented. We should also have a mechanism to remove
// "orphaned" relfiles, if the compute node crashes before writing
// the COMMIT/ABORT record.
Unlink,
}

2
vendor/postgres vendored

Submodule vendor/postgres updated: 928beb4241...a08f50cba2