rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-24 08:30:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

what if we Box the SmgrOpTimerInner

Browse Source
This commit is contained in:
Christian Schwarz
2025-02-07 11:02:30 +01:00
parent 1686d9e733
commit a0e8b1617b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pageserver/src/metrics.rs
View File

@@ -1245,7 +1245,7 @@ pub(crate) mod virtual_file_io_engine {
});
}
pub(crate) struct SmgrOpTimer(Option<SmgrOpTimerInner>);
pub(crate) struct SmgrOpTimer(Option<Box<SmgrOpTimerInner>>);
pub(crate) struct SmgrOpTimerInner {
global_execution_latency_histo: Histogram,
per_timeline_execution_latency_histo: Option<Histogram>,
@@ -1401,7 +1401,7 @@ impl SmgrOpTimer {
global_flush_in_progress_micros,
per_timeline_flush_in_progress_micros,
..
} = inner;
} = *inner;
Some(SmgrOpFlushInProgress {
flush_started_at: at,
global_micros: global_flush_in_progress_micros,
@@ -1794,7 +1794,7 @@ impl SmgrQueryTimePerTimeline {
None
};
SmgrOpTimer(Some(SmgrOpTimerInner {
SmgrOpTimer(Some(Box::new(SmgrOpTimerInner {
global_execution_latency_histo: self.global_latency[op as usize].clone(),
per_timeline_execution_latency_histo: per_timeline_latency_histo,
global_flush_in_progress_micros: self.global_flush_in_progress_micros.clone(),
@@ -1805,7 +1805,7 @@ impl SmgrQueryTimePerTimeline {
per_timeline_batch_wait_time: self.per_timeline_batch_wait_time.clone(),
throttling: self.throttling.clone(),
timings: SmgrOpTimerState::Received { received_at },
}))
})))
}
/// TODO: do something about this? seems odd, we have a similar call on SmgrOpTimer