rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-11 07:22:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Another 'tablespace' test fix.

Browse Source
This commit is contained in:
Heikki Linnakangas
2022-03-11 00:53:46 +02:00
parent 3948956e87
commit bce2da4e55
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
pageserver/src/basebackup.rs
View File

@@ -202,7 +202,24 @@ impl<'a> Basebackup<'a> {
warn!("global/pg_filenode.map is missing");
}
} else {
// User defined tablespaces are not supported
// User defined tablespaces are not supported. However, as
// a special case, if a tablespace/db directory is
// completely empty, we can leave it out altogether. This
// makes taking a base backup after the 'tablespace'
// regression test pass, because the test drops the
// created tablespaces after the tests.
//
// FIXME: this wouldn't be necessary, if we handled
// XLOG_TBLSPC_DROP records. But we probably should just
// throw an error on CREATE TABLESPACE in the first place.
if !has_relmap_file
&& self
.timeline
.list_rels(spcnode, dbnode, self.lsn)?
.is_empty()
{
return Ok(());
}
assert!(spcnode == pg_constants::DEFAULTTABLESPACE_OID);
// Append dir path for each database