rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-16 18:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

page_service client: address todo / unused warning

Browse Source
This commit is contained in:
Christian Schwarz
2025-01-08 17:59:44 +01:00
parent f6f947e4ec
commit c36cf79ab5
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pageserver/client/src/page_service.rs
View File

@@ -118,7 +118,7 @@ impl PagestreamClient {
cancel_on_client_drop: cancel_conn_task,
conn_task,
} = { self };
// The `copy_both` contains internal channel sender, the receiver of which is polled by `conn_task`.
// The `copy_both` split into `sink` and `stream` contains internal channel sender, the receiver of which is polled by `conn_task`.
// When `conn_task` observes the sender has been dropped, it sends a `FeMessage::CopyFail` into the connection.
// (see https://github.com/neondatabase/rust-postgres/blob/2005bf79573b8add5cf205b52a2b208e356cc8b0/tokio-postgres/src/copy_both.rs#L56).
//
@@ -138,7 +138,9 @@ impl PagestreamClient {
let _ = cancel_conn_task.unwrap();
conn_task.await.unwrap();
// TODO: figure out what to do about sink & stream
// Now drop the split copy_both.
drop(sink);
drop(stream);
}
pub async fn getpage(