rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-25 17:10:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove Layer::get_key_range, all unused impls

Browse Source
This commit is contained in:
Joonas Koivunen
2023-08-22 00:27:50 +03:00
parent e80d5bee24
commit ddd4752c43
5 changed files with 0 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pageserver/src/tenant/storage_layer.rs
View File

@@ -344,9 +344,6 @@ impl LayerAccessStats {
/// are used in (timeline).
#[async_trait::async_trait]
pub trait Layer: std::fmt::Debug + std::fmt::Display + Send + Sync + 'static {
/// Range of keys that this layer covers
fn get_key_range(&self) -> Range<Key>;
/// Inclusive start bound of the LSN range that this layer holds
/// Exclusive end bound of the LSN range that this layer holds.
///

8
pageserver/src/tenant/storage_layer/delta_layer.rs
View File

@@ -255,10 +255,6 @@ impl Layer for DeltaLayer {
.await
}
fn get_key_range(&self) -> Range<Key> {
self.get_key_range()
}
fn get_lsn_range(&self) -> Range<Lsn> {
self.get_lsn_range()
}
@@ -394,10 +390,6 @@ impl DeltaLayer {
.await
}
pub(crate) fn get_key_range(&self) -> Range<Key> {
self.layer_desc().key_range.clone()
}
pub(crate) fn get_lsn_range(&self) -> Range<Lsn> {
self.layer_desc().lsn_range.clone()
}

9
pageserver/src/tenant/storage_layer/image_layer.rs
View File

@@ -186,11 +186,6 @@ impl Layer for ImageLayer {
.await
}
/// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.
fn get_key_range(&self) -> Range<Key> {
self.get_key_range()
}
/// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.
fn get_lsn_range(&self) -> Range<Lsn> {
self.get_lsn_range()
@@ -288,10 +283,6 @@ impl ImageLayer {
.with_context(|| format!("read {}", self.path().display()))
}
pub(crate) fn get_key_range(&self) -> Range<Key> {
self.layer_desc().key_range.clone()
}
/// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.
pub(crate) fn get_lsn_range(&self) -> Range<Lsn> {
self.layer_desc().lsn_range.clone()

8
pageserver/src/tenant/storage_layer/inmemory_layer.rs
View File

@@ -107,10 +107,6 @@ impl InMemoryLayer {
self.end_lsn.get().copied().unwrap_or(Lsn::MAX)
}
pub(crate) fn get_key_range(&self) -> Range<Key> {
Key::MIN..Key::MAX
}
pub(crate) fn get_lsn_range(&self) -> Range<Lsn> {
self.start_lsn..self.end_lsn_or_max()
}
@@ -222,10 +218,6 @@ impl InMemoryLayer {
#[async_trait::async_trait]
impl Layer for InMemoryLayer {
fn get_key_range(&self) -> Range<Key> {
self.get_key_range()
}
fn get_lsn_range(&self) -> Range<Lsn> {
self.get_lsn_range()
}

5
pageserver/src/tenant/storage_layer/remote_layer.rs
View File

@@ -95,11 +95,6 @@ impl Layer for RemoteLayer {
Ok(())
}
/// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.
fn get_key_range(&self) -> Range<Key> {
self.layer_desc().key_range.clone()
}
/// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.
fn get_lsn_range(&self) -> Range<Lsn> {
self.layer_desc().lsn_range.clone()