rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-18 13:40:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

expand comment on why we normalize_lsn

Browse Source
This commit is contained in:
Christian Schwarz
2025-07-20 22:38:07 +00:00
parent 2a89f72389
commit f4b38d5975
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pageserver/src/tenant/timeline.rs
View File

@@ -1798,8 +1798,14 @@ impl Timeline {
_ctx: &RequestContext,
) -> anyhow::Result<LsnLease> {
let lease = {
// Normalize the requested LSN to be aligned, and move to the first record
// if it points to the beginning of the page (header).
// Static (=fixed-lsn) computes request basebackup @ X
// but pageserver returns basebackup @ normalize_lsn(X).
// Once the postgres process is started, it will therefore
// request pages@normalize_lsn(X).
// But compute_ctl, which isn't aware that the requested
// basebackup lsn != the returned basebackup LSN, will
// call this API with X.
// So, normalize_lsn(X) here as well.
let lsn = xlog_utils::normalize_lsn(lsn, WAL_SEGMENT_SIZE);
let mut gc_info = self.gc_info.write().unwrap();