rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-28 02:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix comment in find_lsn_for_timestamp (#5855)

Browse Source 
We still subtract 1 from low to compute `commit_lsn`. the comment
moved/added by #5844 should point this out.
This commit is contained in:
Arpad Müller
2023-11-11 01:32:00 +01:00
committed by GitHub
parent 74d150ba45
commit f7249b9018
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pageserver/src/pgdatadir_mapping.rs
View File

@@ -402,8 +402,9 @@ impl Timeline {
low = mid + 1;
}
}
// If `found_smaller == true`, `low` is the LSN of the last commit record
// before or at `search_timestamp`
// If `found_smaller == true`, `low = t + 1` where `t` is the target LSN,
// so the LSN of the last commit record before or at `search_timestamp`.
// Remove one from `low` to get `t`.
//
// FIXME: it would be better to get the LSN of the previous commit.
// Otherwise, if you restore to the returned LSN, the database will