rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-01-15 01:12:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3136: test_tenant_detach_smoke now does not do compaction before GC

Browse Source 
The test started failing after 6dec85b19d because
a single call to a gc HTTP endpoint was prepended with a compaction endpoint.
The former does create a task which detachment waits for, the latter does not.

This test does not seem to care about gc outcome at all, so removing compaction
seems safe. The underlying issue is still there: the compaction HTTP endpoint
can race with tenant detachment. We only use the endpoint in testing, so it may
be worth checking other tests altered in the aforementioned commit.
This commit is contained in:
Egor Suvorov
2022-12-29 01:19:26 +02:00
parent 172c7e5f92
commit ffbe4ca8c8
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test_runner/regress/test_tenant_detach.py
View File

@@ -24,7 +24,6 @@ def do_gc_target(
"""Hack to unblock main, see https://github.com/neondatabase/neon/issues/2211"""
try:
log.info("sending gc http request")
pageserver_http.timeline_checkpoint(tenant_id, timeline_id)
pageserver_http.timeline_gc(tenant_id, timeline_id, 0)
except Exception as e:
log.error("do_gc failed: %s", e)