Commit Graph

3749 Commits

Author SHA1 Message Date
Joonas Koivunen 6f0ab326b4 doc: inmemlayer: cleanup comments 2023-08-28 14:24:38 +03:00
Joonas Koivunen c06a4fb511 doc: delete fixme about gentlemans agreements and strings 2023-08-28 14:19:11 +03:00
Joonas Koivunen 9a714ac6b8 doc: link to LayerMap::search 2023-08-28 14:10:49 +03:00
Joonas Koivunen 8c21edc9c5 doc: cleanup, add missing "the" 2023-08-28 14:10:49 +03:00
Joonas Koivunen 6ff324a12d doc: link to inmemorylayer 2023-08-28 14:10:49 +03:00
Joonas Koivunen 090f9a5a80 doc: remove obsolete comment 2023-08-28 14:01:56 +03:00
Joonas Koivunen 74aefa0b07 heavier_once_cell: explain away the unsynchornized 2023-08-28 13:59:08 +03:00
Joonas Koivunen ce1abef0bd doc: fix typo 2023-08-28 13:53:57 +03:00
Joonas Koivunen 53eacacb6b botched rebase: lost impl AsRe<DeltaLayerInner> 2023-08-28 13:47:03 +03:00
Joonas Koivunen d40b9a515a refactor: split guard_against_eviction into three
- download
- keep_resident
- download_and_keep_resident

No need to bool enum.
2023-08-28 13:35:53 +03:00
Joonas Koivunen 7c2f687bd6 rename: garbage_collect => &_on_drop 2023-08-28 13:35:53 +03:00
Joonas Koivunen effc151244 fix: allow dropping from UploadQueue by spawn_blocking 2023-08-28 13:35:53 +03:00
Joonas Koivunen bdfc895642 layer: remove dead comment and code 2023-08-28 13:35:53 +03:00
Joonas Koivunen 96161c8cfd restore Layer::dump 2023-08-28 13:35:47 +03:00
Joonas Koivunen da99399d16 doc: minor fixes 2023-08-28 13:34:34 +03:00
Joonas Koivunen 7eb74d3720 test: fix allowed error typo 2023-08-28 13:34:34 +03:00
Joonas Koivunen 7b39681caf fix: delete and only then report evicted 2023-08-28 13:34:34 +03:00
Joonas Koivunen 5ff5c580ad test: fix test_timeline_deletion_with_files_stuck_in_upload_queue string change 2023-08-28 13:34:34 +03:00
Joonas Koivunen 6ccc6cbc69 refactor: minor cleanup, doc 2023-08-28 13:34:34 +03:00
Joonas Koivunen 2ecf6727c5 refactor: split evicting 2023-08-28 13:34:34 +03:00
Joonas Koivunen f957616f1c refactor: split get_or_maybe_download 2023-08-28 13:34:34 +03:00
Joonas Koivunen b154a5e908 doc: few touches 2023-08-28 13:34:34 +03:00
Joonas Koivunen c66e859bcc try to apply backoff *after* download
might not work as we could get cancelled, but doing it right before
seems wrong as well. We already retry the download.
2023-08-28 13:34:34 +03:00
Joonas Koivunen 1559ef36af fix: rename the written out file in Layer ctor 2023-08-28 13:34:34 +03:00
Joonas Koivunen ef1c3d3914 test: use guard_against_eviction from outside 2023-08-28 13:34:34 +03:00
Joonas Koivunen 83e28083b0 test: migrate to Layer::for_resident 2023-08-28 13:34:34 +03:00
Joonas Koivunen 0950f8c752 refactor: Layer initialization 2023-08-28 13:34:34 +03:00
Joonas Koivunen 41d36b65e2 move Layer and all to storage_layer::layer 2023-08-28 13:34:34 +03:00
Joonas Koivunen d8cb81118a reorder, get rid of TODO 2023-08-28 13:34:34 +03:00
Joonas Koivunen ecf34bb3e4 blanket rename 2023-08-28 13:34:34 +03:00
Joonas Koivunen fb4d404553 refactor: LayerManager, remove arc 2023-08-28 13:34:34 +03:00
Joonas Koivunen 450f79b3f5 refactor: fix residency and metrics to layermanager 2023-08-28 13:34:34 +03:00
Joonas Koivunen a47b7d1d4c LayerE::drop comments 2023-08-28 13:34:34 +03:00
Joonas Koivunen b01022d8df drop TODO about better load time api 2023-08-28 13:34:34 +03:00
Joonas Koivunen 0155ff95e7 doc: address review comment by jcsp 2023-08-28 13:34:34 +03:00
Joonas Koivunen 46b6a1a5e8 review comment: xref tested string 2023-08-28 13:34:34 +03:00
Joonas Koivunen 290f121b59 ======= address reviews 2023-08-28 13:34:34 +03:00
Joonas Koivunen 786ddeff62 layere: comment cleanup 2023-08-28 13:34:34 +03:00
Joonas Koivunen 732e155b8e fixup remove ability to have 'static DeltaEntry 2023-08-28 13:34:32 +03:00
Joonas Koivunen e10c5b0a9b needsdownload: remove unused 2023-08-28 12:49:56 +03:00
Joonas Koivunen b608eaa410 layere: remove unused LayerE::new 2023-08-28 12:49:56 +03:00
Joonas Koivunen 7b2ae073f0 cleanup unused code, comments 2023-08-28 12:49:56 +03:00
Joonas Koivunen d4a7bdad55 fix: move metric updates to finish_compact_l0 2023-08-28 12:49:56 +03:00
Joonas Koivunen 96c9fd330c fix: duplicate residency events on flushing l0 2023-08-28 12:49:56 +03:00
Joonas Koivunen 39b85cc6fd layere: record residency changes with download/evict 2023-08-28 12:49:56 +03:00
Joonas Koivunen eccb868a50 doc: consider cancellation and redownload 2023-08-28 12:49:56 +03:00
Joonas Koivunen de93c70f2f provide and use LayerE::for_evicted 2023-08-28 12:49:56 +03:00
Joonas Koivunen 72430eb539 layere: remove impossible error case 2023-08-28 12:49:56 +03:00
Joonas Koivunen e2443a0147 remove ability to have 'static DeltaEntry 2023-08-28 12:49:55 +03:00
Joonas Koivunen e5d00b6c2a fix: compaction can and should use borrowed DeltaEntrys
otherwise we risk evicting the L0 while we are reading different blobs
out of it.
2023-08-28 12:46:55 +03:00