Joonas Koivunen
96161c8cfd
restore Layer::dump
2023-08-28 13:35:47 +03:00
Joonas Koivunen
da99399d16
doc: minor fixes
2023-08-28 13:34:34 +03:00
Joonas Koivunen
7eb74d3720
test: fix allowed error typo
2023-08-28 13:34:34 +03:00
Joonas Koivunen
7b39681caf
fix: delete and only then report evicted
2023-08-28 13:34:34 +03:00
Joonas Koivunen
5ff5c580ad
test: fix test_timeline_deletion_with_files_stuck_in_upload_queue string change
2023-08-28 13:34:34 +03:00
Joonas Koivunen
6ccc6cbc69
refactor: minor cleanup, doc
2023-08-28 13:34:34 +03:00
Joonas Koivunen
2ecf6727c5
refactor: split evicting
2023-08-28 13:34:34 +03:00
Joonas Koivunen
f957616f1c
refactor: split get_or_maybe_download
2023-08-28 13:34:34 +03:00
Joonas Koivunen
b154a5e908
doc: few touches
2023-08-28 13:34:34 +03:00
Joonas Koivunen
c66e859bcc
try to apply backoff *after* download
...
might not work as we could get cancelled, but doing it right before
seems wrong as well. We already retry the download.
2023-08-28 13:34:34 +03:00
Joonas Koivunen
1559ef36af
fix: rename the written out file in Layer ctor
2023-08-28 13:34:34 +03:00
Joonas Koivunen
ef1c3d3914
test: use guard_against_eviction from outside
2023-08-28 13:34:34 +03:00
Joonas Koivunen
83e28083b0
test: migrate to Layer::for_resident
2023-08-28 13:34:34 +03:00
Joonas Koivunen
0950f8c752
refactor: Layer initialization
2023-08-28 13:34:34 +03:00
Joonas Koivunen
41d36b65e2
move Layer and all to storage_layer::layer
2023-08-28 13:34:34 +03:00
Joonas Koivunen
d8cb81118a
reorder, get rid of TODO
2023-08-28 13:34:34 +03:00
Joonas Koivunen
ecf34bb3e4
blanket rename
2023-08-28 13:34:34 +03:00
Joonas Koivunen
fb4d404553
refactor: LayerManager, remove arc
2023-08-28 13:34:34 +03:00
Joonas Koivunen
450f79b3f5
refactor: fix residency and metrics to layermanager
2023-08-28 13:34:34 +03:00
Joonas Koivunen
a47b7d1d4c
LayerE::drop comments
2023-08-28 13:34:34 +03:00
Joonas Koivunen
b01022d8df
drop TODO about better load time api
2023-08-28 13:34:34 +03:00
Joonas Koivunen
0155ff95e7
doc: address review comment by jcsp
2023-08-28 13:34:34 +03:00
Joonas Koivunen
46b6a1a5e8
review comment: xref tested string
2023-08-28 13:34:34 +03:00
Joonas Koivunen
290f121b59
======= address reviews
2023-08-28 13:34:34 +03:00
Joonas Koivunen
786ddeff62
layere: comment cleanup
2023-08-28 13:34:34 +03:00
Joonas Koivunen
732e155b8e
fixup remove ability to have 'static DeltaEntry
2023-08-28 13:34:32 +03:00
Joonas Koivunen
e10c5b0a9b
needsdownload: remove unused
2023-08-28 12:49:56 +03:00
Joonas Koivunen
b608eaa410
layere: remove unused LayerE::new
2023-08-28 12:49:56 +03:00
Joonas Koivunen
7b2ae073f0
cleanup unused code, comments
2023-08-28 12:49:56 +03:00
Joonas Koivunen
d4a7bdad55
fix: move metric updates to finish_compact_l0
2023-08-28 12:49:56 +03:00
Joonas Koivunen
96c9fd330c
fix: duplicate residency events on flushing l0
2023-08-28 12:49:56 +03:00
Joonas Koivunen
39b85cc6fd
layere: record residency changes with download/evict
2023-08-28 12:49:56 +03:00
Joonas Koivunen
eccb868a50
doc: consider cancellation and redownload
2023-08-28 12:49:56 +03:00
Joonas Koivunen
de93c70f2f
provide and use LayerE::for_evicted
2023-08-28 12:49:56 +03:00
Joonas Koivunen
72430eb539
layere: remove impossible error case
2023-08-28 12:49:56 +03:00
Joonas Koivunen
e2443a0147
remove ability to have 'static DeltaEntry
2023-08-28 12:49:55 +03:00
Joonas Koivunen
e5d00b6c2a
fix: compaction can and should use borrowed DeltaEntrys
...
otherwise we risk evicting the L0 while we are reading different blobs
out of it.
2023-08-28 12:46:55 +03:00
Joonas Koivunen
dc97970215
chore(ref): make pub
2023-08-28 12:46:53 +03:00
Joonas Koivunen
bc5a643c19
fix: use new LayerE::for_resident
2023-08-28 12:43:11 +03:00
Joonas Koivunen
b1134f6857
layere: add new ctor
2023-08-28 12:43:11 +03:00
Joonas Koivunen
04ab9b78fe
test: add more allowed outcomes
...
I cannot see a quick fix to make one them winner, nor a reason why it
should be done; at worst case there could be double accounting for some
evicted layer should the two do it at the same time.
2023-08-28 12:43:11 +03:00
Joonas Koivunen
fa0b881c4c
remove previous generation of Layer, PersistentLayer
...
- remove get_value_reconstruct_data for Delta, Image
- remove unnecessary default trait method
- remove trait PersistentLayer
- remove unused {Delta,Image}Layer::new()
- continued dead code removal
- unify ImageLayer to be like DeltaLayer
- dead code and imports cleanup
- remove PathOrConfig
- correct few doc links re: Layer removal
2023-08-28 12:43:11 +03:00
Joonas Koivunen
106bda1ef9
layer_map: finally remove replacement related tests
2023-08-28 12:43:11 +03:00
Joonas Koivunen
c2de71e1fe
test: fix test_timeline_deletion_with_files_stuck_in_upload_queue, global allowed_error
2023-08-28 12:43:11 +03:00
Joonas Koivunen
3eba531c3d
test: fixup layere error type introduction, string change
2023-08-28 12:43:11 +03:00
Joonas Koivunen
088bea8680
test: add hint about mismatch cause
2023-08-28 12:43:11 +03:00
Joonas Koivunen
a9b0ac92bc
layere: decrement resident size if removed
...
make the problem of not knowing more explicit.
2023-08-28 12:43:11 +03:00
Joonas Koivunen
3045956ddd
refactor(LayerE): use new internal api
2023-08-28 12:43:11 +03:00
Joonas Koivunen
599069b612
eviction: remove comment
2023-08-28 12:43:11 +03:00
Joonas Koivunen
54873844c2
layere: introduce internal error type
2023-08-28 12:43:11 +03:00
