mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-05 12:32:54 +00:00
## Problem The nightly test discovered problems in the extensions upgrade test. 1. `PLv8` has different versions on PGv17 and PGv16 and a different test set, which was not implemented correctly [sample](https://github.com/neondatabase/neon/actions/runs/13382330475/job/37372930271) 2. The same for `semver` [sample](https://github.com/neondatabase/neon/actions/runs/13382330475/job/37372930017) 3. `pgtap` interfered with the other tests, e.g. tables, created by other extensions caused the tests to fail. ## Summary of changes The discovered problems were fixed. 1. The tests list for `PLv8` is now generated using the original Makefile 2. The patches for `semver` are now split for PGv16 and PGv17. 3. `pgtap` is being tested in a separate database now. --------- Co-authored-by: Mikhail Kot <mikhail@neon.tech>
29 lines
1.2 KiB
Diff
29 lines
1.2 KiB
Diff
diff --git a/Makefile b/Makefile
|
|
index f255fe6..0a0fa65 100644
|
|
--- a/Makefile
|
|
+++ b/Makefile
|
|
@@ -346,7 +346,7 @@ test: test-serial test-parallel
|
|
TB_DIR = test/build
|
|
GENERATED_SCHEDULE_DEPS = $(TB_DIR)/all_tests $(TB_DIR)/exclude_tests
|
|
REGRESS = --schedule $(TB_DIR)/run.sch # Set this again just to be safe
|
|
-REGRESS_OPTS = --inputdir=test --max-connections=$(PARALLEL_CONN) --schedule $(SETUP_SCH) $(REGRESS_CONF)
|
|
+REGRESS_OPTS = --use-existing --dbname=pgtap_regression --inputdir=test --max-connections=$(PARALLEL_CONN) --schedule $(SETUP_SCH) $(REGRESS_CONF)
|
|
SETUP_SCH = test/schedule/main.sch # schedule to use for test setup; this can be forcibly changed by some targets!
|
|
IGNORE_TESTS = $(notdir $(EXCLUDE_TEST_FILES:.sql=))
|
|
PARALLEL_TESTS = $(filter-out $(IGNORE_TESTS),$(filter-out $(SERIAL_TESTS),$(ALL_TESTS)))
|
|
diff --git a/test/schedule/create.sql b/test/schedule/create.sql
|
|
index ba355ed..7e250f5 100644
|
|
--- a/test/schedule/create.sql
|
|
+++ b/test/schedule/create.sql
|
|
@@ -1,3 +1,2 @@
|
|
\unset ECHO
|
|
\i test/psql.sql
|
|
-CREATE EXTENSION pgtap;
|
|
diff --git a/test/schedule/main.sch b/test/schedule/main.sch
|
|
index a8a5fbc..0463fc4 100644
|
|
--- a/test/schedule/main.sch
|
|
+++ b/test/schedule/main.sch
|
|
@@ -1,2 +1 @@
|
|
-test: build
|
|
test: create
|