neon/src at e3ff87ce3bfa99662a9b2d299b78be1bfa35b8cd - neon

rust/neon

mirror of https://github.com/neondatabase/neon.git synced 2026-01-13 00:12:54 +00:00

Files

John Spray e3ff87ce3b tests: avoid using background_process when invoking pg_ctl (#9469 )

## Problem

Occasionally, we get failures to start the storage controller's db with
errors like:
```
aborting due to panic at /__w/neon/neon/control_plane/src/background_process.rs:349:67:
claim pid file: lock file

Caused by:
    file is already locked
```
e.g.
https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9428/11380574562/index.html#/testresult/1c68d413ea9ecd4a

This is happening in a stop,start cycle during a test. Presumably the
pidfile from the startup background process is still held at the point
we stop, because we let pg_ctl keep running in the background.

## Summary of changes

- Refactor pg_ctl invocations into a helper
- In the controller's `start` function, use pg_ctl & a wait loop for
pg_isready, instead of using background_process

---------

Co-authored-by: Arpad Müller <arpad-m@users.noreply.github.com>

2024-10-23 16:29:55 +00:00

bin

neon_local: Use clap derive macros to parse the CLI args (#9103 )

2024-09-27 22:08:46 +03:00

background_process.rs

neon_local start: parallel startup to break cyclic dependency (#8950 )

2024-09-18 18:17:55 +02:00

branch_mappings.rs

neon_local: Use clap derive macros to parse the CLI args (#9103 )

2024-09-27 22:08:46 +03:00

broker.rs

Fix comment in Control Plane (#8406 )