rust/tantivy
1
0
Fork 0
mirror of https://github.com/quickwit-oss/tantivy.git synced 2026-01-08 18:12:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Allow zero indexing & merging threads (#59)

Browse Source 
This removes a check against `IndexWriterOptions` which disallowed zero indexing worker threads (`num_worker_threads`).
This commit is contained in:
Eric Ridge
2025-08-11 07:46:37 -04:00
committed by Stu Hood
parent c96d801c68
commit b6cd39872b
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/indexer/index_writer.rs
View File

@@ -313,8 +313,8 @@ impl<D: Document> IndexWriter<D> {
return Err(TantivyError::InvalidArgument(err_msg));
}
if options.num_worker_threads == 0 {
let err_msg = "At least one worker thread is required, got 0".to_string();
return Err(TantivyError::InvalidArgument(err_msg));
// let err_msg = "At least one worker thread is required, got 0".to_string();
// return Err(TantivyError::InvalidArgument(err_msg));
}
let (document_sender, document_receiver) =
@@ -2635,10 +2635,15 @@ mod tests {
let _field = schema_builder.add_bool_field("example", STORED);
let index = Index::create_in_ram(schema_builder.build());
// NB: tantivy proper probably can't work with zero worker threads, but we (pg_search) do
// indexing and merging in the foreground and don't need the worker threads
let opt_wo_threads = IndexWriterOptions::builder().num_worker_threads(0).build();
let result = index.writer_with_options::<TantivyDocument>(opt_wo_threads);
assert!(result.is_err(), "Writer should reject 0 thread count");
assert!(matches!(result, Err(TantivyError::InvalidArgument(_))));
assert!(result.is_ok(), "Writer should accept 0 thread count");
// the above actually created a writer which then takes a lock, which causes the next
// attempt to open an IndexWriter to fail in a way that's different than expected.
// Dropping the Result<IndexWriter> we just made lets the test carry on unchanged
drop(result);
let opt_with_low_memory = IndexWriterOptions::builder()
.memory_budget_per_thread(10 << 10)