ci: automate homebrew cask release for macos

.github/workflows/release.yml

@@ -12,7 +12,7 @@ on:
   workflow_dispatch:
 
 permissions:
-  contents: write # needed to create / update the GitHub Release
+  contents: write   # needed to create / update the GitHub Release
 
 jobs:
   build:
@@ -26,15 +26,15 @@ jobs:
             target: x86_64-pc-windows-msvc
             name: windows-x86_64
             bin: ashell.exe
-          - os: ubuntu-22.04 # build on the oldest supported runner for broader glibc compatibility
+          - os: ubuntu-22.04            # build on the oldest supported runner for broader glibc compatibility
             target: x86_64-unknown-linux-gnu
             name: linux-x86_64
             bin: ashell
-          - os: macos-14 # Apple Silicon
+          - os: macos-14               # Apple Silicon
             target: aarch64-apple-darwin
             name: macos-aarch64
             bin: ashell
-          - os: macos-14 # Intel (cross-compiled from Apple Silicon to avoid queue delays)
+          - os: macos-14               # Intel (cross-compiled from Apple Silicon to avoid queue delays)
             target: x86_64-apple-darwin
             name: macos-x86_64
             bin: ashell
@@ -80,7 +80,7 @@ jobs:
             # Note: We build the bundle manually here rather than running
             # scripts/package-macos-app.sh, because that script runs `cargo build`
             # without respecting the `--target` flag from the matrix.
-
+            
             APP="ashell.app"
             CONTENTS="$APP/Contents"
             mkdir -p "$CONTENTS/MacOS" "$CONTENTS/Resources"
@@ -193,21 +193,22 @@ jobs:
           VERSION=${GITHUB_REF#refs/tags/v}
           SHA_ARM=$(sha256sum dist/macos-aarch64/*.zip | cut -d' ' -f1)
           SHA_INTEL=$(sha256sum dist/macos-x86_64/*.zip | cut -d' ' -f1)
-
+          
           mkdir -p tap/Casks
           CASK_FILE="tap/Casks/ashell.rb"
-
-          cat > "$CASK_FILE" <<EOF
+          
+          if [ ! -f "$CASK_FILE" ]; then
+            cat > "$CASK_FILE" <<'EOF'
           cask "ashell" do
-            version "${VERSION}"
-
+            version "0.0.0"
+            
             on_arm do
-              sha256 "${SHA_ARM}"
-              url "https://github.com/rust-kotlin/ashell/releases/download/v#{version}/ashell-v#{version}-macos-aarch64.zip"
+              sha256 "0"
+              url "https://github.com/rust-kotlin/ashell/releases/download/v#{version}/ashell-#{version}-macos-aarch64.zip"
             end
             on_intel do
-              sha256 "${SHA_INTEL}"
-              url "https://github.com/rust-kotlin/ashell/releases/download/v#{version}/ashell-v#{version}-macos-x86_64.zip"
+              sha256 "0"
+              url "https://github.com/rust-kotlin/ashell/releases/download/v#{version}/ashell-#{version}-macos-x86_64.zip"
             end
 
             name "ashell"
@@ -215,26 +216,15 @@ jobs:
             homepage "https://github.com/rust-kotlin/ashell"
 
             app "ashell.app"
-
-            postflight do
-              puts "Removing quarantine flag from ashell.app..."
-              system_command "/usr/bin/xattr",
-                             args: ["-rd", "com.apple.quarantine", "#{appdir}/ashell.app"],
-                             sudo: true
-            end
-
-            caveats <<~EOS
-              ashell uses ad-hoc signing. The installation includes a postflight script
-              that removes the 'com.apple.quarantine' attribute from the application
-              to allow it to run. This will require your administrator password.
-
-              ashell 采用本地签名。安装程序包含一个后置脚本，用于移除应用程序的
-              'com.apple.quarantine' 属性以允许其运行。这需要您的管理员密码。
-            EOS
           end
           EOF
-          # Remove the 10 leading spaces added for YAML formatting
-          sed -i 's/^          //' "$CASK_FILE"
+            # Remove the 10 leading spaces added for YAML formatting
+            sed -i 's/^          //' "$CASK_FILE"
+          fi
+          
+          sed -i "s|version \".*\"|version \"${VERSION}\"|" "$CASK_FILE"
+          sed -i "/on_arm do/,/end/ s|sha256 \".*\"|sha256 \"${SHA_ARM}\"|" "$CASK_FILE"
+          sed -i "/on_intel do/,/end/ s|sha256 \".*\"|sha256 \"${SHA_INTEL}\"|" "$CASK_FILE"
 
       - name: Commit and Push
         run: |

Cargo.lock

@@ -303,7 +303,7 @@ dependencies = [
 
 [[package]]
 name = "ashell"
-version = "0.4.6"
+version = "0.4.4"
 dependencies = [
  "alacritty_terminal",
  "anyhow",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ashell"
-version = "0.4.6"
+version = "0.4.4"
 edition = "2024"
 authors = ["ashell contributors"]
 description = "A GPUI Component based SSH and local terminal client"

README.en.md

@@ -24,28 +24,8 @@ You can download the latest pre-compiled releases for macOS, Windows, and Linux
 
 ## Mac Installation Guide
 
-### Method 1: Homebrew (Recommended)
-
-If you use [Homebrew](https://brew.sh/), you can install it quickly with:
-
-```bash
-brew install rust-kotlin/taps/ashell --cask
-```
-
-To update the app:
-
-```bash
-brew update
-brew upgrade ashell --cask
-```
-
-> **Note**: Since the app uses ad-hoc signing, the Homebrew installation or update includes a postflight script to automatically handle the quarantine flag. This will require you to enter your administrator password for authorization.
-
-### Method 2: Manual Download
-
-1. Download and unzip from the [Releases page](https://github.com/rust-kotlin/ashell/releases/latest).
-2. Move `ashell.app` to your **Applications** folder. 
-3. Since the app uses ad-hoc signing, macOS may warn that the app is "damaged" upon first launch. If this happens, open Terminal and run:
+After downloading, please unzip the file and move `ashell.app` to your **Applications** folder. 
+Since the app uses ad-hoc signing, macOS may warn that the app is "damaged" upon first launch. If this happens, open Terminal and run the following command:
 
 ```bash
 sudo xattr -cr /Applications/ashell.app

README.md

@@ -24,28 +24,8 @@ v0.4 在 v0.3 打下的基础上，重点带来了更完整的工作区操作能
 
 ## Mac 安装指南
 
-### 方法 1: Homebrew 安装 (推荐)
-
-如果您使用 [Homebrew](https://brew.sh/)，可以通过以下命令快速安装：
-
-```bash
-brew install rust-kotlin/taps/ashell --cask
-```
-
-更新应用：
-
-```bash
-brew update
-brew upgrade ashell --cask
-```
-
-> **注意**: 由于应用采用本地签名，Homebrew 在安装或更新过程中会执行一个后置脚本来自动处理隔离属性（quarantine flag），这需要您输入管理员密码以授权。
-
-### 方法 2: 手动下载
-
-1. 从 [Releases 页面](https://github.com/rust-kotlin/ashell/releases/latest) 下载并解压。
-2. 将 `ashell.app` 拖入或移动到 **应用程序 (Applications)** 目录。
-3. 由于应用采用本地签名，初次启动时如果系统提示“App 已损坏，无法打开”，请打开终端（Terminal）并执行以下命令：
+下载并解压后，请先将 `ashell.app` 拖入或移动到 **应用程序 (Applications)** 目录。
+由于应用采用本地签名，初次启动时如果系统提示“App 已损坏，无法打开”，请打开终端（Terminal）并执行以下命令：
 
 ```bash
 sudo xattr -cr /Applications/ashell.app

locales/en.yml

@@ -154,7 +154,3 @@ settings_split_pane_up: "Split Pane Up"
 settings_split_pane_down: "Split Pane Down"
 settings_close_pane: "Close Pane"
 keybind_conflict: '"%{key}" is already used by "%{action}", please choose another key'
-title_bar_style: "Title Bar Style"
-title_bar_native: "Native"
-title_bar_integrated: "Integrated"
-restart_hint: " (Restart required)"

locales/zh-CN.yml

@@ -156,7 +156,3 @@ settings_split_pane_up: "向上拆分面板"
 settings_split_pane_down: "向下拆分面板"
 settings_close_pane: "关闭当前面板"
 keybind_conflict: '"%{key}" 已被「%{action}」使用，请选择其他快捷键'
-title_bar_style: "标题栏样式"
-title_bar_native: "原生"
-title_bar_integrated: "融合"
-restart_hint: " (修改后重启生效)"

src/app/dialogs.rs

@@ -160,11 +160,7 @@ impl Ashell {
                                         .child(
                                             Button::new("connect-ssh-cancel")
                                                 .label(t!("cancel").to_string())
-                                                .on_click(window.listener_for(&view, |this, _, window, cx| {
-                                                    this.active_dialog = None;
-                                                    window.close_dialog(cx);
-                                                    cx.notify();
-                                                })),
+                                                .on_click(|_, window, cx| window.close_dialog(cx)),
                                         )
                                         .child(
                                             Button::new("connect-ssh-confirm")
@@ -263,10 +259,8 @@ impl Ashell {
                                         .on_mouse_down(
                                             MouseButton::Left,
                                             window.listener_for(&view, |this, _, window, cx| {
-                                                this.active_dialog = None;
                                                 this.open_local(cx);
                                                 window.close_dialog(cx);
-                                                cx.notify();
                                             }),
                                         )
                                         .child(
@@ -307,10 +301,8 @@ impl Ashell {
                                         .on_mouse_down(
                                             MouseButton::Left,
                                             window.listener_for(&view, |this, _, window, cx| {
-                                                this.active_dialog = None;
                                                 window.close_dialog(cx);
                                                 this.open_new_ssh_dialog(window, cx);
-                                                cx.notify();
                                             }),
                                         )
                                         .child(
@@ -378,13 +370,11 @@ impl Ashell {
                                                         window.listener_for(
                                                             &view,
                                                             move |this, _, window, cx| {
-                                                                this.active_dialog = None;
                                                                 this.connect_saved_session(
                                                                     connect_id.clone(),
                                                                     cx,
                                                                 );
                                                                 window.close_dialog(cx);
-                                                                cx.notify();
                                                             },
                                                         ),
                                                     )
@@ -523,11 +513,9 @@ impl Ashell {
                                     .small()
                                     .ghost()
                                     .icon(IconName::Close)
-                                    .on_click(window.listener_for(&view, |this, _, window, cx| {
-                                        this.active_dialog = None;
+                                    .on_click(|_, window, cx| {
                                         window.close_dialog(cx);
-                                        cx.notify();
-                                    })),
+                                    }),
                             ),
                         );
 
@@ -1297,50 +1285,6 @@ impl Ashell {
                                                         })
                                                     )
                                                 )
-                                                .item(
-                                                    SettingItem::new(
-                                                        format!("{}{}", t!("title_bar_style"), t!("restart_hint")),
-                                                        SettingField::render({
-                                                            let view = view_clone_for_general.clone();
-                                                            move |_, _window, cx| {
-                                                                let current_style = view.read(cx).config.title_bar_style();
-                                                                Button::new("title-bar-style-dropdown")
-                                                                    .small()
-                                                                    .label(match current_style {
-                                                                        crate::session::config::TitleBarStyle::Native => t!("title_bar_native").to_string(),
-                                                                        crate::session::config::TitleBarStyle::Integrated => t!("title_bar_integrated").to_string(),
-                                                                    })
-                                                                    .dropdown_menu_with_anchor(Anchor::BottomRight, {
-                                                                        let view = view.clone();
-                                                                        move |mut menu, window, cx| {
-                                                                            let current_style = view.read(cx).config.title_bar_style();
-                                                                            menu = menu.min_w(160.)
-                                                                                .item(
-                                                                                    PopupMenuItem::new(t!("title_bar_native").to_string())
-                                                                                        .checked(current_style == crate::session::config::TitleBarStyle::Native)
-                                                                                        .on_click(window.listener_for(&view, |this, _, _, cx| {
-                                                                                            this.config.set_title_bar_style(crate::session::config::TitleBarStyle::Native);
-                                                                                            let _ = this.config.save();
-                                                                                            cx.notify();
-                                                                                        }))
-                                                                                )
-                                                                                .item(
-                                                                                    PopupMenuItem::new(t!("title_bar_integrated").to_string())
-                                                                                        .checked(current_style == crate::session::config::TitleBarStyle::Integrated)
-                                                                                        .on_click(window.listener_for(&view, |this, _, _, cx| {
-                                                                                            this.config.set_title_bar_style(crate::session::config::TitleBarStyle::Integrated);
-                                                                                            let _ = this.config.save();
-                                                                                            cx.notify();
-                                                                                        }))
-                                                                                );
-                                                                            menu
-                                                                        }
-                                                                    })
-                                                                    .into_any_element()
-                                                            }
-                                                        })
-                                                    )
-                                                )
                                         )
                                         .group(
                                             SettingGroup::new()

src/app/mod.rs

@@ -258,7 +258,6 @@ pub(crate) struct Ashell {
     pub(crate) prev_monitoring_size: Option<Pixels>,
     pub(crate) status: SharedString,
     pub(crate) config: ConfigStore,
-    pub(crate) active_title_bar_style: crate::session::config::TitleBarStyle,
     pub(crate) system_sampler: SystemSampler,
     pub(crate) recording_action: Option<String>,
     pub(crate) active_dialog: Option<DialogKind>,
@@ -483,7 +482,6 @@ impl Ashell {
             collapsed_saved_scroll_handle: gpui::ScrollHandle::new(),
             prev_monitoring_size: None,
             status: "ready".into(),
-            active_title_bar_style: config.title_bar_style(),
             config,
             system_sampler,
             recording_action: None,

src/app/startup.rs

@@ -176,23 +176,14 @@ pub(crate) fn sync_macos_launch_environment() {
 pub(crate) fn sync_macos_launch_environment() {}
 
 pub(crate) fn open_main_window(cx: &mut App) {
-    let config = ConfigStore::load().unwrap_or_else(|_| ConfigStore::in_memory());
-
     let mut window_options = WindowOptions::default();
 
-    if config.title_bar_style() == crate::session::config::TitleBarStyle::Integrated {
-        window_options.titlebar = Some(gpui::TitlebarOptions {
-            title: None,
-            appears_transparent: true,
-            traffic_light_position: Some(gpui::point(px(9.0), px(9.0))),
-        });
-    }
-
     #[cfg(not(target_os = "macos"))]
     if let Ok(img) = image::load_from_memory(include_bytes!("../../assets/icons/ashell.png")) {
         window_options.icon = Some(std::sync::Arc::new(img.into_rgba8()));
     }
 
+    let config = ConfigStore::load().unwrap_or_else(|_| ConfigStore::in_memory());
     if let Some(bounds) = config.window_bounds() {
         window_options.window_bounds = Some(match bounds {
             crate::session::config::SavedWindowBounds::Fullscreen {

src/app/ui.rs

@@ -1,12 +1,12 @@
 use gpui::{
     Context, ElementId, Focusable as _, FontWeight, Hsla, InteractiveElement as _, IntoElement,
     MouseButton, MouseDownEvent, ParentElement as _, PathBuilder, Pixels, Render,
-    StatefulInteractiveElement as _, Styled as _, Window, canvas, div, hsla,
-    point, prelude::FluentBuilder as _, px, rems, uniform_list,
+    StatefulInteractiveElement as _, Styled as _, Window, canvas, div, point,
+    prelude::FluentBuilder as _, px, rems, uniform_list,
 };
 use gpui_component::{
-    ActiveTheme, Disableable as _, ElementExt, Icon, IconName, InteractiveElementExt as _, Root,
-    Size, Sizable as _, button::{Button, ButtonVariants as _},
+    ActiveTheme, Disableable as _, ElementExt, Icon, IconName, Root, Size, Sizable as _,
+    button::{Button, ButtonVariants as _},
     checkbox::Checkbox,
     h_flex,
     input::Input,
@@ -1541,7 +1541,6 @@ impl Ashell {
                                 Button::new("sidebar-collapse-toggle")
                                     .ghost()
                                     .icon(IconName::PanelLeftClose)
-                                    .tooltip(t!("settings_toggle_sidebar").to_string())
                                     .on_click(cx.listener(|this, _, _, cx| {
                                         this.sidebar_collapsed = true;
                                         this.config.set_sidebar_collapsed(true);
@@ -1553,7 +1552,6 @@ impl Ashell {
                                 Button::new("sidebar-settings")
                                     .ghost()
                                     .icon(IconName::Settings)
-                                    .tooltip(t!("settings_open_settings").to_string())
                                     .on_click(cx.listener(|this, _, window, cx| {
                                         this.show_settings_dialog(window, cx)
                                     })),
@@ -1774,7 +1772,6 @@ impl Ashell {
                         Button::new("sidebar-expand-toggle")
                             .ghost()
                             .icon(IconName::PanelLeftOpen)
-                            .tooltip(t!("settings_toggle_sidebar").to_string())
                             .on_click(cx.listener(|this, _, _, cx| {
                                 this.sidebar_collapsed = false;
                                 this.config.set_sidebar_collapsed(false);
@@ -1896,58 +1893,6 @@ impl Ashell {
             )
     }
 
-    fn render_window_controls(&self, window: &mut Window, _cx: &mut Context<Self>) -> impl IntoElement {
-        let is_macos = cfg!(target_os = "macos");
-        let is_fullscreen = window.is_fullscreen();
-
-        h_flex()
-            .flex_none()
-            .items_center()
-            .px_3()
-            .gap_2()
-            .when(!is_macos || is_fullscreen, |this| {
-                this.child(
-                    div()
-                        .id("window-close")
-                        .size(px(12.))
-                        .rounded_full()
-                        .bg(hsla(0.0, 0.8, 0.4, 1.0)) // Red
-                        .on_click(|_, window, _| window.remove_window())
-                        .hover(|s| s.bg(hsla(0.0, 0.8, 0.5, 1.0)))
-                        .active(|s| s.bg(hsla(0.0, 0.8, 0.3, 1.0))),
-                )
-                .child(
-                    div()
-                        .id("window-minimize")
-                        .size(px(12.))
-                        .rounded_full()
-                        .bg(hsla(0.12, 0.8, 0.4, 1.0)) // Yellow
-                        .on_click(|_, window, _| window.minimize_window())
-                        .hover(|s| s.bg(hsla(0.12, 0.8, 0.5, 1.0)))
-                        .active(|s| s.bg(hsla(0.12, 0.8, 0.3, 1.0))),
-                )
-                .child(
-                    div()
-                        .id("window-maximize")
-                        .size(px(12.))
-                        .rounded_full()
-                        .bg(hsla(0.33, 0.8, 0.4, 1.0)) // Green
-                        .on_click(|_, window, _| {
-                            if window.is_fullscreen() {
-                                window.toggle_fullscreen();
-                            } else {
-                                window.zoom_window();
-                            }
-                        })
-                        .hover(|s| s.bg(hsla(0.33, 0.8, 0.5, 1.0)))
-                        .active(|s| s.bg(hsla(0.33, 0.8, 0.3, 1.0))),
-                )
-            })
-            .when(is_macos, |this| {
-                this.when(!is_fullscreen, |this| this.w(px(80.)))
-            })
-    }
-
     fn render_tab_bar(&self, cx: &mut Context<Self>) -> impl IntoElement {
         let active_tab_index = self
             .active_tab
@@ -1971,137 +1916,147 @@ impl Ashell {
                 (g.id.clone(), g.title.clone(), pane_ids)
             })
             .collect();
-        let is_integrated =
-            self.active_title_bar_style == crate::session::config::TitleBarStyle::Integrated;
-
-        h_flex()
-            .flex_1()
-            .min_w(px(0.))
-            .h_full()
-            .items_center()
-            .gap_2()
-            .child(
-                div()
-                    .flex_1()
-                    .min_w(px(0.))
-                    .h_full()
-                    .when(is_integrated, |this| {
-                        this.window_control_area(gpui::WindowControlArea::Drag)
-                    })
-                    .overflow_x_hidden()
-                    .child({
-                        TabBar::new("ashell-tab-bar")
-                            .track_scroll(&self.tabs_scroll_handle)
-                            .selected_index(selected)
-                            .children(groups_data.iter().enumerate().map(
-                                |(ix, (group_id, title, pane_ids))| {
-                                    let gid = group_id.clone();
-                                    let label = if pane_ids.len() > 1 {
-                                        format!("{} ({})", title, pane_ids.len())
-                                    } else {
-                                        title.clone()
-                                    };
-                                    let close_id = if self.active_group.as_ref() == Some(&gid) {
-                                        self.active_tab.clone().unwrap_or_else(|| {
-                                            pane_ids.first().cloned().unwrap_or_default()
-                                        })
-                                    } else {
-                                        pane_ids.first().cloned().unwrap_or_default()
-                                    };
-
-                                    let dot_color = pane_ids
-                                        .first()
-                                        .and_then(|id| self.tabs.iter().find(|t| t.id == *id))
-                                        .map(|tab| {
-                                            if tab.connected {
-                                                cx.theme().success
-                                            } else {
-                                                cx.theme().danger
-                                            }
-                                        })
-                                        .unwrap_or(cx.theme().success);
-                                    Tab::new()
-                                        .min_w(px(80.))
-                                        .prefix(div().w(px(5.)).h(px(32.)).bg(dot_color))
-                                        .child(
-                                            div()
-                                                .when(ix == selected, |this| {
-                                                    this.font_weight(FontWeight::BOLD)
-                                                        .text_color(cx.theme().primary)
-                                                        .text_base()
-                                                })
-                                                .child(label),
-                                        )
-                                        .on_click(cx.listener(move |this, _, window, cx| {
-                                            this.activate_group(gid.clone(), window, cx)
-                                        }))
-                                        .suffix(
-                                            Button::new(("tab-close", ix))
-                                                .ghost()
-                                                .xsmall()
-                                                .icon(IconName::Close)
-                                                .mr(px(5.))
-                                                .on_mouse_down(MouseButton::Left, |_, window, cx| {
-                                                    window.prevent_default();
-                                                    cx.stop_propagation();
-                                                })
-                                                .on_click(cx.listener(move |this, _, window, cx| {
-                                                    window.prevent_default();
-                                                    cx.stop_propagation();
-                                                    if !close_id.is_empty() {
-                                                        this.close_tab(close_id.clone(), cx)
-                                                    }
-                                                })),
-                                        )
-                                },
-                            ))
-                            .last_empty_space(div().w_3())
-                            .w_full()
-                            .h_full()
-                    }),
-            )
+        v_flex()
+            .h(px(32.))
+            .w_full()
+            .flex_none()
+            .bg(cx.theme().tab_bar)
             .child(
                 h_flex()
-                    .flex_none()
+                    .h_full()
+                    .w_full()
                     .items_center()
-                    .gap_1()
-                    .pr(px(6.))
+                    .gap_2()
                     .child(
-                        Button::new("open-selector")
-                            .secondary()
-                            .small()
-                            .rounded(px(999.))
-                            .icon(IconName::Plus)
-                            .tooltip(t!("settings_open_session").to_string())
-                            .on_click(cx.listener(|this, _, window, cx| {
-                                this.show_selector_dialog(window, cx)
-                            })),
+                        div()
+                            .flex_1()
+                            .min_w(px(0.))
+                            .h_full()
+                            .overflow_x_hidden()
+                            .child({
+                                TabBar::new("ashell-tab-bar")
+                                    .track_scroll(&self.tabs_scroll_handle)
+                                    .selected_index(selected)
+                                    .children(groups_data.iter().enumerate().map(
+                                        |(ix, (group_id, title, pane_ids))| {
+                                            let gid = group_id.clone();
+                                            let label = if pane_ids.len() > 1 {
+                                                format!("{} ({})", title, pane_ids.len())
+                                            } else {
+                                                title.clone()
+                                            };
+                                            let close_id = if self.active_group.as_ref()
+                                                == Some(&gid)
+                                            {
+                                                self.active_tab.clone().unwrap_or_else(|| {
+                                                    pane_ids.first().cloned().unwrap_or_default()
+                                                })
+                                            } else {
+                                                pane_ids.first().cloned().unwrap_or_default()
+                                            };
+                                            let dot_color = pane_ids
+                                                .first()
+                                                .and_then(|id| {
+                                                    self.tabs.iter().find(|t| t.id == *id)
+                                                })
+                                                .map(|tab| {
+                                                    if tab.connected {
+                                                        cx.theme().success
+                                                    } else {
+                                                        cx.theme().danger
+                                                    }
+                                                })
+                                                .unwrap_or(cx.theme().success);
+                                            Tab::new()
+                                                .min_w(px(80.))
+                                                .prefix(div().w(px(5.)).h(px(32.)).bg(dot_color))
+                                                .child(
+                                                    div()
+                                                        .when(ix == selected, |this| {
+                                                            this.font_weight(FontWeight::BOLD)
+                                                                .text_color(cx.theme().primary)
+                                                                .text_base()
+                                                        })
+                                                        .child(label),
+                                                )
+                                                .on_click(cx.listener(
+                                                    move |this, _, window, cx| {
+                                                        this.activate_group(gid.clone(), window, cx)
+                                                    },
+                                                ))
+                                                .suffix(
+                                                    Button::new(("tab-close", ix))
+                                                        .ghost()
+                                                        .xsmall()
+                                                        .icon(IconName::Close)
+                                                        .mr(px(5.))
+                                                        .on_mouse_down(
+                                                            MouseButton::Left,
+                                                            |_, window, cx| {
+                                                                window.prevent_default();
+                                                                cx.stop_propagation();
+                                                            },
+                                                        )
+                                                        .on_click(cx.listener(
+                                                            move |this, _, window, cx| {
+                                                                window.prevent_default();
+                                                                cx.stop_propagation();
+                                                                if !close_id.is_empty() {
+                                                                    this.close_tab(
+                                                                        close_id.clone(),
+                                                                        cx,
+                                                                    )
+                                                                }
+                                                            },
+                                                        )),
+                                                )
+                                        },
+                                    ))
+                                    .last_empty_space(div().w_3())
+                                    .w_full()
+                                    .h_full()
+                            }),
                     )
                     .child(
-                        Button::new("split-horizontal")
-                            .secondary()
-                            .small()
-                            .rounded(px(999.))
-                            .icon(IconName::PanelBottom)
-                            .tooltip(t!("settings_split_pane_down").to_string())
-                            .on_click(cx.listener(|this, _, window, cx| {
-                                window.prevent_default();
-                                cx.stop_propagation();
-                                this.split_current_pane("down", cx);
-                            })),
-                    )
-                    .child(
-                        Button::new("split-vertical")
-                            .secondary()
-                            .small()
-                            .rounded(px(999.))
-                            .icon(IconName::PanelRight)
-                            .tooltip(t!("settings_split_pane_right").to_string())
-                            .on_click(cx.listener(|this, _, window, cx| {
-                                window.prevent_default();
-                                cx.stop_propagation();
-                                this.split_current_pane("right", cx);
-                            })),
+                        h_flex()
+                            .flex_none()
+                            .items_center()
+                            .gap_1()
+                            .pr(px(6.))
+                            .child(
+                                Button::new("open-selector")
+                                    .secondary()
+                                    .small()
+                                    .rounded(px(999.))
+                                    .icon(IconName::Plus)
+                                    .on_click(cx.listener(|this, _, window, cx| {
+                                        this.show_selector_dialog(window, cx)
+                                    })),
+                            )
+                            .child(
+                                Button::new("split-horizontal")
+                                    .secondary()
+                                    .small()
+                                    .rounded(px(999.))
+                                    .icon(IconName::PanelBottom)
+                                    .on_click(cx.listener(|this, _, window, cx| {
+                                        window.prevent_default();
+                                        cx.stop_propagation();
+                                        this.split_current_pane("down", cx);
+                                    })),
+                            )
+                            .child(
+                                Button::new("split-vertical")
+                                    .secondary()
+                                    .small()
+                                    .rounded(px(999.))
+                                    .icon(IconName::PanelRight)
+                                    .on_click(cx.listener(|this, _, window, cx| {
+                                        window.prevent_default();
+                                        cx.stop_propagation();
+                                        this.split_current_pane("right", cx);
+                                    })),
+                            ),
                     ),
             )
     }
@@ -2470,21 +2425,7 @@ impl Render for Ashell {
                                 .size_full()
                                 .relative()
                                 .overflow_hidden()
-                                .when(
-                                    self.active_title_bar_style == crate::session::config::TitleBarStyle::Native,
-                                    |this| {
-                                        this.child(
-                                            div()
-                                                .flex_none()
-                                                .h(px(32.))
-                                                .w_full()
-                                                .bg(cx.theme().tab_bar)
-                                                .border_b_1()
-                                                .border_color(cx.theme().border)
-                                                .child(self.render_tab_bar(cx)),
-                                        )
-                                    },
-                                )
+                                .child(self.render_tab_bar(cx))
                                 .child(body_panel),
                         ),
                 )
@@ -2505,21 +2446,7 @@ impl Render for Ashell {
                     .size_full()
                     .relative()
                     .overflow_hidden()
-                    .when(
-                        self.active_title_bar_style == crate::session::config::TitleBarStyle::Native,
-                        |this| {
-                            this.child(
-                                div()
-                                    .flex_none()
-                                    .h(px(32.))
-                                    .w_full()
-                                    .bg(cx.theme().tab_bar)
-                                    .border_b_1()
-                                    .border_color(cx.theme().border)
-                                    .child(self.render_tab_bar(cx)),
-                            )
-                        },
-                    )
+                    .child(self.render_tab_bar(cx))
                     .child(body_panel),
             );
 
@@ -2530,7 +2457,7 @@ impl Render for Ashell {
                 .into_any_element()
         };
 
-        v_flex()
+        div()
             .id("ashell-root")
             .size_full()
             .bg(cx.theme().background)
@@ -2562,34 +2489,7 @@ impl Render for Ashell {
                     this.close_tab(active_id, cx);
                 }
             }))
-            .when(self.active_title_bar_style == crate::session::config::TitleBarStyle::Integrated, |this| {
-                this.child(
-                    div()
-                        .id("title-bar")
-                        .flex()
-                        .items_center()
-                        .h(px(34.))
-                        .w_full()
-                        .bg(cx.theme().tab_bar)
-                        .on_double_click(|_, window, _| {
-                            #[cfg(target_os = "macos")]
-                            window.titlebar_double_click();
-                            #[cfg(not(target_os = "macos"))]
-                            window.zoom_window();
-                        })
-                        .child(self.render_window_controls(window, cx))
-                        .child(
-                            div()
-                                .flex_1()
-                                .min_w(px(0.))
-                                .h_full()
-                                .child(self.render_tab_bar(cx)),
-                        ),
-                )
-            })
-            .child(
-                div().flex_1().min_h_0().child(workspace),
-            )
+            .child(workspace)
             .children(Root::render_dialog_layer(window, cx))
             .children(Root::render_sheet_layer(window, cx))
             .when_some(self.sftp_context_menu.clone(), |this, menu| {

src/session/config.rs

@@ -98,14 +98,6 @@ pub enum SavedWindowBounds {
     },
 }
 
-#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, Default)]
-#[serde(rename_all = "lowercase")]
-pub enum TitleBarStyle {
-    Native,
-    #[default]
-    Integrated,
-}
-
 #[derive(Debug, Clone, Serialize, Deserialize, Default)]
 pub struct ConfigFile {
     #[serde(default = "default_follow_system_theme")]
@@ -129,8 +121,6 @@ pub struct ConfigFile {
     #[serde(default = "default_terminal_font_family")]
     pub terminal_font_family: String,
     #[serde(default)]
-    pub title_bar_style: TitleBarStyle,
-    #[serde(default)]
     pub sessions: Vec<Session>,
     #[serde(default)]
     pub window_bounds: Option<SavedWindowBounds>,
@@ -416,14 +406,6 @@ impl ConfigStore {
         self.cache.terminal_font_family = family.to_string();
     }
 
-    pub fn title_bar_style(&self) -> TitleBarStyle {
-        self.cache.title_bar_style
-    }
-
-    pub fn set_title_bar_style(&mut self, style: TitleBarStyle) {
-        self.cache.title_bar_style = style;
-    }
-
     pub fn show_hidden_files(&self) -> bool {
         self.cache.show_hidden_files
     }

src/session/mod.rs

@@ -113,9 +113,7 @@ impl Ashell {
 
         self.open_ssh_session(session, cx);
         self.editing_session_id = None;
-        self.active_dialog = None;
         window.close_dialog(cx);
-        cx.notify();
     }
 
     pub(crate) fn set_input_value(
@@ -370,7 +368,6 @@ impl Ashell {
             return;
         };
 
-        self.active_dialog = None;
         match entry {
             SelectorEntry::Local => {
                 self.open_local(cx);
@@ -385,7 +382,6 @@ impl Ashell {
                 window.close_dialog(cx);
             }
         }
-        cx.notify();
     }
 
     pub(crate) fn on_selector_key_down(