mirror of
https://github.com/daijro/camoufox.git
synced 2026-10-04 16:00:21 +00:00
Jake WriterandClaude Opus 5.5
73f81b2543
The fpgen model was staged in tempfile.mkdtemp() and os.replace'd into fpgen's data directory, and an extracted GeoIP database was unpacked in tempfile.TemporaryDirectory() and shutil.move'd into the cache. Since Python 3.13, mkdtemp() on Windows creates an owner-only directory, and a file moved out of it on the same volume keeps that ACL. So a model or database installed from an elevated shell (or over SSH, which is elevated) could not be read by the same user unelevated, or by any other account: the launch failed with "fpgen's model directory is not writable by this user", though the failure was a read. Found on Windows 11 with camoufox 0.5.7b5 under Python 3.14. Add pkgman.write_atomic(): write a temporary file beside the destination, so it takes the directory's permissions, then os.replace it into place. The model's members are all verified before any is written, as before. The permission error now names the file and says how to recover from a model another account installed. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
123 lines
4.5 KiB
Python
123 lines
4.5 KiB
Python
"""Which GeoIP source is active, and when its database is refreshed."""
|
|
|
|
import os
|
|
import time
|
|
import warnings
|
|
|
|
import pytest
|
|
from yaml import safe_dump
|
|
|
|
from camoufox import geolocation
|
|
|
|
DEFAULT = "GeoIP AIO by daijro"
|
|
DEPRECATED = "MaxMind GeoLite2"
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def cache(tmp_path, monkeypatch):
|
|
monkeypatch.setattr(geolocation, "GEOIP_DIR", tmp_path)
|
|
monkeypatch.setattr(geolocation, "MMDB_DIR", tmp_path / "mmdb")
|
|
monkeypatch.setattr(geolocation, "GEOIP_CONFIG", tmp_path / "config.yml")
|
|
return tmp_path
|
|
|
|
|
|
def _saved(cache, **fields):
|
|
(cache / "config.yml").write_text(safe_dump(fields))
|
|
|
|
|
|
def test_default_is_aio():
|
|
assert geolocation.load_geoip_config()["name"] == DEFAULT
|
|
repos, _ = geolocation._load_geoip_repos()
|
|
assert [r["name"] for r in repos if r.get("deprecated")] == [DEPRECATED]
|
|
|
|
|
|
def test_implicit_deprecated_source_moves_to_default(cache):
|
|
# What every cache written before the default changed holds
|
|
_saved(cache, name=DEPRECATED)
|
|
assert geolocation.load_geoip_config()["name"] == DEFAULT
|
|
|
|
|
|
def test_explicit_deprecated_source_is_kept(cache):
|
|
_saved(cache, name=DEPRECATED, explicit=True)
|
|
assert geolocation.load_geoip_config()["name"] == DEPRECATED
|
|
|
|
|
|
def test_save_records_explicit_choice(cache):
|
|
config = geolocation._get_geoip_config_by_name(DEPRECATED)
|
|
geolocation.save_geoip_config(config, explicit=True)
|
|
assert geolocation.load_geoip_config()["name"] == DEPRECATED
|
|
geolocation.save_geoip_config(config)
|
|
assert geolocation.load_geoip_config()["name"] == DEFAULT
|
|
|
|
|
|
def test_refresh_keeps_an_explicit_choice(cache, monkeypatch):
|
|
# `camoufox fetch` and the weekly refresh download without naming a source
|
|
_saved(cache, name=DEPRECATED, explicit=True)
|
|
monkeypatch.setattr(geolocation, "webdl", lambda url, buffer, **kw: buffer.write(b"x"))
|
|
monkeypatch.setattr(geolocation, "_build_age_days", lambda path: 1)
|
|
geolocation.download_mmdb()
|
|
assert geolocation.load_geoip_config()["name"] == DEPRECATED
|
|
|
|
|
|
def test_deprecated_source_warns():
|
|
with warnings.catch_warnings(record=True) as caught:
|
|
warnings.simplefilter("always")
|
|
geolocation.warn_if_deprecated(geolocation._get_geoip_config_by_name(DEPRECATED))
|
|
geolocation.warn_if_deprecated(geolocation._get_geoip_config_by_name(DEFAULT))
|
|
assert [w.category for w in caught] == [FutureWarning]
|
|
assert DEFAULT in str(caught[0].message)
|
|
|
|
|
|
def _database(cache, checked_days_ago):
|
|
config = geolocation.load_geoip_config()
|
|
path = geolocation.get_mmdb_path("ipv4", config)
|
|
path.parent.mkdir(parents=True, exist_ok=True)
|
|
path.write_bytes(b"")
|
|
stamp = time.time() - checked_days_ago * 86400
|
|
os.utime(path, (stamp, stamp))
|
|
return config
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"checked, built, stale",
|
|
[
|
|
(0.5, 400, False), # checked today: wait, even for an old build
|
|
(2, 3, False), # this week's build
|
|
(2, 9, True), # a release has been missed
|
|
(40, 3, False), # an old file holding a new build is not stale
|
|
(2, None, True), # unreadable database
|
|
],
|
|
)
|
|
def test_needs_update_reads_the_build_date(cache, monkeypatch, checked, built, stale):
|
|
config = _database(cache, checked)
|
|
monkeypatch.setattr(geolocation, "_build_age_days", lambda path: built)
|
|
assert geolocation.needs_update(config) is stale
|
|
|
|
|
|
def test_missing_database_needs_update():
|
|
assert geolocation.needs_update() is True
|
|
|
|
|
|
@pytest.mark.skipif(os.name == "nt", reason="POSIX mode bits stand in for the Windows ACL")
|
|
def test_the_database_takes_its_directory_permissions_not_the_staging_files(cache, monkeypatch):
|
|
# The archive is unpacked in a private temporary directory. Since Python
|
|
# 3.13 that directory is owner-only on Windows, and a file moved out of it
|
|
# keeps that ACL, so another account or elevation level could not read the
|
|
# database. An owner-only staged file reproduces that here.
|
|
def unzip(zip_file, extract_path, **kw):
|
|
fd = os.open(os.path.join(extract_path, "geoip.mmdb"), os.O_WRONLY | os.O_CREAT, 0o600)
|
|
os.write(fd, b"db")
|
|
os.close(fd)
|
|
|
|
monkeypatch.setattr(geolocation, "webdl", lambda url, buffer, **kw: buffer.write(b"zip"))
|
|
monkeypatch.setattr(geolocation, "unzip", unzip)
|
|
monkeypatch.setattr(geolocation, "_build_age_days", lambda path: 1)
|
|
geolocation.download_mmdb()
|
|
|
|
mmdb = geolocation.get_mmdb_path("ipv4")
|
|
umask = os.umask(0)
|
|
os.umask(umask)
|
|
assert mmdb.read_bytes() == b"db"
|
|
assert mmdb.stat().st_mode & 0o777 == 0o666 & ~umask
|
|
assert not list(mmdb.parent.glob(".*.tmp"))
|