starred/herdr
1
0
Fork 0
mirror of https://github.com/herdrdev/herdr.git synced 2026-11-06 08:06:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: detect codex startup update chooser (#5174)

Browse Source 
refs #4811
This commit is contained in:
Can Celik
2026-10-12 16:22:24 +03:00
committed by GitHub
parent dc6b6e5f42
commit 6d697e1e75
3 changed files with 75 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
distribution/agent-detection/codex.toml
+15 -4
View File
@@ -1,7 +1,7 @@
id = "codex"
version = "2026.10.01.1"
version = "2026.10.11.1"
min_engine_version = 3
updated_at = "2026-10-01T00:00:00Z"
updated_at = "2026-10-11T00:00:00Z"
[[rules]]
id = "osc_title_blocked"
@@ -60,8 +60,19 @@ state = "blocked"
priority = 950
region = "bottom_non_empty_lines(20)"
visible_blocker = true
contains = ["Update available!", "Update now"]
regex = ['Skip\s+until\s+next\s+version', 'Press enter to continue\s*\z']
# Keep the legacy dialog; the shared picker (0.159+) has a different heading
# and footer. Choices can scroll out of a short viewport, but both gates must
# remain visible. The passive update history notice has neither picker footer.
any = [
{ all = [
{ contains = ["Update available!", "Update now"] },
{ regex = ['Skip\s+until\s+next\s+version', 'Press enter to continue\s*\z'] },
] },
{ all = [
{ regex = ['(?m)^\s*Update\s+available\s+·'] },
{ regex = ['enter\s+continue\s+·\s+esc\s+skip\s*\z'] },
] },
]
[[rules]]
id = "live_strong_blocker"
src/detect/manifest/tests.rs
+45
View File
@@ -157,6 +157,51 @@ line_regex = ["^exact line$"]
});
}
#[test]
fn paired_alternatives_require_complete_gates_at_bottom_buffer() {
with_manifest_dirs("paired-alternatives", || {
write_local_codex(&rules_manifest(
r#"
[[rules]]
id = "paired"
state = "blocked"
region = "bottom_non_empty_lines(3)"
visible_blocker = true
any = [
{ all = [
{ contains = ["alpha heading"] },
{ regex = ['alpha\s+control\s*\z'] },
] },
{ all = [
{ contains = ["beta heading"] },
{ regex = ['beta\s+control\s*\z'] },
] },
]
"#,
));
for text in [
"alpha heading\nalpha control",
"beta heading\nbeta\ncontrol",
] {
let result = explain(Agent::Codex, text);
assert_eq!(result.state, AgentState::Blocked);
assert!(result.visible_blocker);
}
for text in [
"alpha heading\nbeta control",
"beta heading\nalpha control",
"beta control",
"beta heading",
"beta heading\nbeta control\nnewer content",
"beta heading\nfiller one\nfiller two\nbeta control",
] {
let result = explain(Agent::Codex, text);
assert!(result.matched_rule.is_none(), "{text}");
assert!(!result.visible_blocker, "{text}");
}
});
}
#[test]
fn remote_manifest_loads_between_local_override_and_bundled() {
with_manifest_dirs("remote-source", || {
src/detect/manifests/codex.toml
+15 -4
View File
@@ -1,7 +1,7 @@
id = "codex"
version = "2026.10.01.1"
version = "2026.10.11.1"
min_engine_version = 3
updated_at = "2026-10-01T00:00:00Z"
updated_at = "2026-10-11T00:00:00Z"
[[rules]]
id = "osc_title_blocked"
@@ -60,8 +60,19 @@ state = "blocked"
priority = 950
region = "bottom_non_empty_lines(20)"
visible_blocker = true
contains = ["Update available!", "Update now"]
regex = ['Skip\s+until\s+next\s+version', 'Press enter to continue\s*\z']
# Keep the legacy dialog; the shared picker (0.159+) has a different heading
# and footer. Choices can scroll out of a short viewport, but both gates must
# remain visible. The passive update history notice has neither picker footer.
any = [
{ all = [
{ contains = ["Update available!", "Update now"] },
{ regex = ['Skip\s+until\s+next\s+version', 'Press enter to continue\s*\z'] },
] },
{ all = [
{ regex = ['(?m)^\s*Update\s+available\s+·'] },
{ regex = ['enter\s+continue\s+·\s+esc\s+skip\s*\z'] },
] },
]
[[rules]]
id = "live_strong_blocker"