mirror of
https://github.com/lexmount/moli.git
synced 2026-11-21 16:03:10 +00:00
fix(media): reject empty local media responses
This commit is contained in:
@@ -4,6 +4,74 @@ use crate::page_task_queue::{
|
||||
PageMediaElementEventTargetEffect, RendererPageMediaElementEventTaskKind,
|
||||
};
|
||||
|
||||
#[tokio::test(flavor = "current_thread")]
|
||||
async fn empty_local_media_fails_before_readiness_without_resetting_controls() {
|
||||
run_page_vm_async_test(async move {
|
||||
for kind in ["audio", "video"] {
|
||||
for source in ["data:,", "data:audio/ogg,", "data:video/webm;base64,"] {
|
||||
let loader = crate::network::ResourceRequestClient::new(&FetchConfig::default())
|
||||
.expect("loader");
|
||||
let (mut page, _source, _wake) = page_vm_with_bound_task_sources_and_owner_wake(
|
||||
&loader,
|
||||
Url::parse("https://empty-local-media.test/")?,
|
||||
);
|
||||
page.vm_mut().eval(&format!(
|
||||
r#"
|
||||
globalThis.emptyMediaTrace = [];
|
||||
globalThis.emptyMedia = document.createElement({kind:?});
|
||||
emptyMedia.defaultMuted = true;
|
||||
emptyMedia.muted = false;
|
||||
emptyMedia.volume = 0.25;
|
||||
for (const type of ['loadstart', 'loadedmetadata', 'loadeddata', 'canplay', 'volumechange']) {{
|
||||
emptyMedia.addEventListener(type, () => emptyMediaTrace.push(type));
|
||||
}}
|
||||
emptyMedia.onerror = () => {{
|
||||
emptyMediaTrace.push('error');
|
||||
emptyMedia.pause();
|
||||
}};
|
||||
setTimeout(() => emptyMediaTrace.push('timer'), 0);
|
||||
emptyMedia.src = {source:?};
|
||||
emptyMedia.play().then(
|
||||
() => emptyMediaTrace.push('fulfilled'),
|
||||
error => emptyMediaTrace.push(error.name)
|
||||
);
|
||||
"#,
|
||||
))?;
|
||||
assert_eq!(page.vm_mut().eval("emptyMediaTrace.join('|')")?, "");
|
||||
let mut tasks = 0;
|
||||
while page
|
||||
.run_exact_selected_page_task_for_test(
|
||||
PageSelectedTaskTestSelector::MediaElementEvent,
|
||||
&loader,
|
||||
)
|
||||
.await?
|
||||
{
|
||||
tasks += 1;
|
||||
anyhow::ensure!(tasks <= 12, "empty media kept scheduling tasks");
|
||||
}
|
||||
assert_eq!(
|
||||
page.vm_mut().eval(
|
||||
r#"emptyMediaTrace.filter(type => type === 'error').length === 1 &&
|
||||
emptyMediaTrace.filter(type => type === 'loadstart').length === 1 &&
|
||||
emptyMediaTrace.indexOf('loadstart') < emptyMediaTrace.indexOf('error') &&
|
||||
emptyMediaTrace.indexOf('error') < emptyMediaTrace.indexOf('NotSupportedError') &&
|
||||
!emptyMediaTrace.some(type => ['loadedmetadata', 'loadeddata', 'canplay', 'volumechange', 'fulfilled', 'timer'].includes(type)) &&
|
||||
emptyMedia.error.code === 4 && emptyMedia.networkState === 3 && emptyMedia.readyState === 0 &&
|
||||
emptyMedia.volume === 0.25 && !emptyMedia.muted && emptyMedia.defaultMuted"#,
|
||||
)?,
|
||||
"true",
|
||||
"{kind}/{source}: {}",
|
||||
page.vm_mut().eval("emptyMediaTrace.join('|')")?
|
||||
);
|
||||
assert!(page.vm().has_ready_timeout());
|
||||
}
|
||||
}
|
||||
Ok::<_, anyhow::Error>(())
|
||||
})
|
||||
.await
|
||||
.expect("empty local media uses the owned error task and rejects pending play");
|
||||
}
|
||||
|
||||
#[tokio::test(flavor = "current_thread")]
|
||||
async fn media_volume_controls_preserve_tasks_realms_defaults_and_brands() {
|
||||
run_page_vm_async_test(async move {
|
||||
|
||||
Reference in New Issue
Block a user