starred/native
1
0
Fork 0
mirror of https://github.com/bulwarkmail/native.git synced 2026-10-31 08:06:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add the template settings strings to the catalog

Browse Source 
TemplateSettings calls the translate function `tr` because `t` is a
template variable there, and both the key harvester and the coverage
test only looked for `t('...')`. Ten of its keys were never added to
locales/rn/en.json, so they could not be translated and the test did
not notice. Both now also match `tr('...')`, and the missing keys are
added.
This commit is contained in:
Linus Rath
2026-09-24 20:49:55 +02:00
parent aab29da148
commit ccdc4dee56
3 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
locales/rn/en.json
+10 -1
View File
@@ -866,7 +866,16 @@
"plugins": "Plugins"
},
"templates": {
"delete_title": "Delete template"
"delete_confirm": "Permanently delete \"{name}\"?",
"delete_title": "Delete template",
"description_mobile": "Reusable snippets for common replies. Tap one to edit; long-press to delete.",
"export_failed": "Export failed",
"import_failed": "Import failed",
"imported": "Imported",
"imported_count": "{count, plural, one {# template} other {# templates}} added.",
"is_html": "Body is HTML",
"placeholders_hint": "Placeholders: {{recipient_name}}, {{company}}, {{date}}, {{day_of_week}}, {{sender_name}}",
"share_unavailable": "Unable to share"
},
"themes": {
"default_description": "The default light and dark palettes.",
scripts/harvest-rn-keys.mjs
+4 -3
View File
@@ -61,9 +61,10 @@ const overlayFlat = flatten(overlay);
// t('key', 'fallback') / t('key', "fallback") / t('key', `fallback`) - the
// fallback may span lines; keep it simple: single-quoted or double-quoted,
// non-nested strings.
const CALL_RE = /\bt\(\s*'([^']+)'\s*,\s*(?:'((?:[^'\\]|\\.)*)'|"((?:[^"\\]|\\.)*)")/g;
const KEY_ONLY_RE = /\bt\(\s*'([^']+)'/g;
// non-nested strings. `tr` is the same function where `t` is taken (a
// template or timer variable).
const CALL_RE = /\btr?\(\s*'([^']+)'\s*,\s*(?:'((?:[^'\\]|\\.)*)'|"((?:[^"\\]|\\.)*)")/g;
const KEY_ONLY_RE = /\btr?\(\s*'([^']+)'/g;
const added = [];
const missingNoFallback = [];
src/i18n/__tests__/keys.test.ts
+4 -4
View File
@@ -34,10 +34,10 @@ function walk(dir: string, out: string[] = []): string[] {
return out;
}
// Literal keys: t('a.b.c', …). Template-literal keys (`settings.tabs.${id}`)
// are checked by prefix below.
const LITERAL_KEY_RE = /\bt\(\s*'([^']+)'/g;
const TEMPLATE_KEY_RE = /\bt\(\s*`([^`$]+)\$\{/g;
// Literal keys: t('a.b.c', …), or tr(…) where `t` is taken. Template-literal
// keys (`settings.tabs.${id}`) are checked by prefix below.
const LITERAL_KEY_RE = /\btr?\(\s*'([^']+)'/g;
const TEMPLATE_KEY_RE = /\btr?\(\s*`([^`$]+)\$\{/g;
// Walking and reading all of src/ synchronously takes under a second on its
// own, but went past the 5 s default (16.8 s) while gradle was building.