starred/openobserve
1
0
Fork 0
mirror of https://github.com/openobserve/openobserve.git synced 2026-11-06 00:09:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow limit zero in context sql_mode (#320)

Browse Source
This commit is contained in:
Hengfei Yang
2023-03-20 12:41:58 +08:00
committed by GitHub
parent dc18b38368
commit 29dd28198e
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/service/search/sql.rs
+5 -3
View File
@@ -30,7 +30,7 @@ use crate::service::stream::get_stream_setting_fts_fields;
use crate::service::{db, file_list, logs};
const SQL_DELIMITERS: [u8; 10] = [b' ', b'*', b'(', b')', b'<', b'>', b',', b';', b'=', b'!'];
const SQL_DEFAULT_LIMIT: usize = 1000;
const SQL_DEFAULT_FULL_MODE_LIMIT: usize = 1000;
#[derive(Clone, Debug, Serialize)]
pub struct Sql {
@@ -267,8 +267,10 @@ impl Sql {
if meta.limit == 0 {
meta.offset = req_query.from as usize;
meta.limit = req_query.size as usize;
if meta.limit == 0 {
meta.limit = SQL_DEFAULT_LIMIT;
if meta.limit == 0 && sql_mode.eq(&SqlMode::Full) {
// sql mode context, allow limit 0, used to no hits, but return aggs
// sql mode full, disallow without limit, default limit 1000
meta.limit = SQL_DEFAULT_FULL_MODE_LIMIT;
}
origin_sql = if meta.order_by.is_empty() {
format!(