mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-04 08:09:27 +00:00
fix: update quick_mode parameter handling in logs URL based on configuration for drilldown and go to logs in dashboard (#8586)
### **PR Type**
Bug fix
___
### **Description**
- Respect `quick_mode_enabled` in logs URL
- Apply to drilldown and go-to-logs flows
- Minor watch formatting cleanup
___
### Diagram Walkthrough
```mermaid
flowchart LR
Config["zoConfig.quick_mode_enabled"]
Builder1["PanelContainer: build logs URL"]
Builder2["PanelSchemaRenderer: build logs URL"]
URLParam["Set quick_mode=true/false"]
Format["Refactor watch() formatting"]
Config -- controls --> Builder1
Config -- controls --> Builder2
Builder1 -- sets --> URLParam
Builder2 -- sets --> URLParam
PanelSchemaRenderer --> Format
```
<details> <summary><h3> File Walkthrough</h3></summary>
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Bug
fix</strong></td><td><table>
<tr>
<td>
<details>
<summary><strong>PanelContainer.vue</strong><dd><code>Conditional
quick_mode in logs URL construction</code>
</dd></summary>
<hr>
web/src/components/dashboards/PanelContainer.vue
<ul><li>Set <code>quick_mode</code> based on
<code>zoConfig.quick_mode_enabled</code>.<br> <li> Remove unconditional
<code>quick_mode=false</code>.</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8586/files#diff-414737cba6064461f7026e0b016afcb9620bd5bb29c4708fc170dee789dbcd4d">+5/-2</a>
</td>
</tr>
<tr>
<td>
<details>
<summary><strong>PanelSchemaRenderer.vue</strong><dd><code>Apply
config-driven quick_mode and tidy watchers</code>
</dd></summary>
<hr>
web/src/components/dashboards/PanelSchemaRenderer.vue
<ul><li>Set <code>quick_mode</code> based on
<code>zoConfig.quick_mode_enabled</code>.<br> <li> Keep histogram
hidden; preserve other params.<br> <li> Reformat watch() for
readability.</ul>
</details>
</td>
<td><a
href="https://github.com/openobserve/openobserve/pull/8586/files#diff-e5376e7e77bf3aaf6590c2522d8c2dbffcc95a8006ae0d6dc0040a37825367d6">+12/-5</a>
</td>
</tr>
</table></td></tr></tr></tbody></table>
</details>
___
This commit is contained in:
@@ -611,9 +611,12 @@ export default defineComponent({
|
||||
"org_identifier",
|
||||
store.state.selectedOrganization.identifier,
|
||||
);
|
||||
logsUrl.searchParams.set("quick_mode", "false");
|
||||
if (store.state.zoConfig.quick_mode_enabled) {
|
||||
logsUrl.searchParams.set("quick_mode", "true");
|
||||
} else {
|
||||
logsUrl.searchParams.set("quick_mode", "false");
|
||||
}
|
||||
logsUrl.searchParams.set("show_histogram", "false");
|
||||
|
||||
return logsUrl;
|
||||
};
|
||||
|
||||
|
||||
@@ -747,10 +747,13 @@ export default defineComponent({
|
||||
{ deep: true },
|
||||
);
|
||||
|
||||
watch(panelData, () => {
|
||||
emit("series-data-update", panelData.value);
|
||||
},
|
||||
{ deep: true });
|
||||
watch(
|
||||
panelData,
|
||||
() => {
|
||||
emit("series-data-update", panelData.value);
|
||||
},
|
||||
{ deep: true },
|
||||
);
|
||||
|
||||
// when we get the new limitNumberOfSeriesWarningMessage from the convertPanelData, emit the limitNumberOfSeriesWarningMessage
|
||||
watch(
|
||||
@@ -1280,7 +1283,11 @@ export default defineComponent({
|
||||
"org_identifier",
|
||||
store.state.selectedOrganization.identifier,
|
||||
);
|
||||
logsUrl.searchParams.set("quick_mode", "false");
|
||||
if (store.state.zoConfig.quick_mode_enabled) {
|
||||
logsUrl.searchParams.set("quick_mode", "true");
|
||||
} else {
|
||||
logsUrl.searchParams.set("quick_mode", "false");
|
||||
}
|
||||
logsUrl.searchParams.set("show_histogram", "false");
|
||||
|
||||
return logsUrl;
|
||||
|
||||
Reference in New Issue
Block a user