mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-05 08:09:22 +00:00
fix: propagate send error correctly (#13598)
Currently if the destination notification fails at connect stage itself,
it logs the error just as error sending request, with no other
information. This PR instead captures the error, and logs the debug fmt
which looks like
```
reqwest::Error { kind: Request, url: "https://localhost:5001/", source: hyper_util::client::legacy::Error(Connect, Custom { kind: Other, error: Custom { kind: InvalidData, error: InvalidMessage(InvalidContentType) } }) }
```
Which provides more info to debug the issue.
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
Co-authored-by: Yashodhan Joshi <yjdoc2@gmail.com>
This commit is contained in:
co-authored by
Yashodhan Joshi
parent
624425a08a
commit
5f8a2f6690
@@ -1702,7 +1702,13 @@ async fn send_http_notification(endpoint: &Endpoint, msg: String) -> Result<Stri
|
||||
req = req.header("Content-type", "application/json");
|
||||
}
|
||||
|
||||
let resp = req.body(msg.clone()).send().await?;
|
||||
let resp = match req.body(msg.clone()).send().await {
|
||||
Ok(v) => v,
|
||||
Err(e) => {
|
||||
log::error!("error sending request to {} with error {e:?}", endpoint.url);
|
||||
return Err(anyhow::anyhow!("error sending request : {e:?}"));
|
||||
}
|
||||
};
|
||||
let resp_status = resp.status();
|
||||
let resp_body = resp.text().await?;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user