mirror of
https://github.com/openobserve/openobserve.git
synced 2026-11-06 00:09:22 +00:00
fix: Saved View preserves loadingHistogram State, leading to track total hits call on applying. (#9084)
#9079 1. A view was saved while the histogram was being loaded, which incorrectly hardcoded the loadingHistogram flag as true in the saved view data. 2. When this saved view was later loaded, the true value of loadingHistogram was retrieved. 3. This pre-existing true state bypassed the histogram loading logic and resulted in an incorrect call to the get page count.
This commit is contained in:
@@ -3228,10 +3228,11 @@ export default defineComponent({
|
||||
});
|
||||
setTimeout(async () => {
|
||||
try {
|
||||
searchObj.loadingHistogram = false;
|
||||
searchObj.loading = true;
|
||||
searchObj.meta.refreshHistogram = true;
|
||||
// TODO OK: Remove all the instances of communicationMethod and below assignment aswell
|
||||
searchObj.communicationMethod = "streaming";
|
||||
searchObj.communicationMethod = "streaming";
|
||||
await extractFields();
|
||||
await getQueryData();
|
||||
store.dispatch("setSavedViewFlag", false);
|
||||
@@ -3411,6 +3412,14 @@ export default defineComponent({
|
||||
delete savedSearchObj.data.savedViews;
|
||||
delete savedSearchObj.data.transforms;
|
||||
|
||||
|
||||
// Turn off all loaders before saving view
|
||||
savedSearchObj.loading = false;
|
||||
savedSearchObj.loadingHistogram = false;
|
||||
savedSearchObj.loadingCounter = false;
|
||||
savedSearchObj.loadingStream = false;
|
||||
savedSearchObj.loadingSavedView = false;
|
||||
|
||||
savedSearchObj.data.timezone = store.state.timezone;
|
||||
|
||||
if (savedSearchObj.data.parsedQuery) {
|
||||
|
||||
Reference in New Issue
Block a user