starred/openobserve
1
0
Fork 0
mirror of https://github.com/openobserve/openobserve.git synced 2026-11-05 00:09:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Fix new UpdateAlert endpoint (#5652)

Browse Source
This commit is contained in:
Patrick Sullivan
2025-01-09 21:42:56 -06:00
committed by GitHub
parent 0383959603
commit c2ccf4a3a1
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/handler/http/models/alerts/mod.rs
+1 -1
View File
@@ -449,7 +449,7 @@ impl From<meta_stream::StreamType> for StreamType {
impl From<Alert> for meta_alerts::alert::Alert {
fn from(value: Alert) -> Self {
Self {
id: None,
id: value.id,
name: value.name,
org_id: value.org_id,
stream_type: value.stream_type.into(),
src/infra/src/table/alerts/mod.rs
+2 -2
View File
@@ -310,7 +310,7 @@ pub async fn create<C: TransactionTrait>(
Ok(alert)
}
/// Creates a new alert in the database. Returns the new alert.
/// Updates an alert in the database. Returns the new alert.
pub async fn update<C: TransactionTrait + ConnectionTrait>(
conn: &C,
org_id: &str,
@@ -319,7 +319,7 @@ pub async fn update<C: TransactionTrait + ConnectionTrait>(
) -> Result<MetaAlert, errors::Error> {
// Ensure that ID is provided.
let Some(alert_id) = alert.id else {
return Err(errors::DbError::PutAlert(PutAlertError::CreateAlertSetID).into());
return Err(errors::DbError::PutAlert(PutAlertError::UpdateAlertMissingID).into());
};
let _lock = super::get_lock().await;