Record automation run selection cleanup in audit (#3103)

2026-09-22 16:02:32 +00:00 · 2026-05-29 04:33:22 -07:00
parent d517772810
commit 017f90ffba
1 changed files with 4 additions and 2 deletions
@@ -49,7 +49,7 @@ Initial inventory:

 Current count after low-risk PRs #3038, #3041, #3042, #3044, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3062, #3063, #3064, #3065, #3066, #3067, #3068, #3069, #3083, #3087, #3091, and #3100: 928 Effect hook call sites.

-Open medium-risk PRs #3070, #3073, #3077, #3089, and #3093 each project to 927 Effect hook call sites on the current merged baseline; open medium-risk PR #3097 projects to 926; open medium-risk PR #3095 projects to 924; open medium-risk PR #3079 projects to 918; open high-risk PR #3075 projects to 924; and open high-risk PR #3081 projects to 920. These are not counted in the merged baseline until reviewed and merged.
+Open medium-risk PRs #3070, #3073, #3077, #3089, #3093, and #3102 each project to 927 Effect hook call sites on the current merged baseline; open medium-risk PR #3097 projects to 926; open medium-risk PR #3095 projects to 924; open medium-risk PR #3079 projects to 918; open high-risk PR #3075 projects to 924; and open high-risk PR #3081 projects to 920. These are not counted in the merged baseline until reviewed and merged.

 | Area                           | Files / signal                                                                                           | Scan status                                   | Notes                                                                                                                              |
 | ------------------------------ | -------------------------------------------------------------------------------------------------------- | --------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------- |
@@ -60,7 +60,7 @@ Open medium-risk PRs #3070, #3073, #3077, #3089, and #3093 each project to 927 E
 | Sidebar / worktrees            | `components/sidebar/**`                                                                                  | Inventory complete, manual review in progress | Orca hook trust checkbox reset covered by #3089. Continue with worktree list state repair, drag/drop global listeners, kanban pointer flows. |
 | Right sidebar / source control | `components/right-sidebar/**`                                                                            | Inventory complete, manual review pending     | Check polling, PR checks, file explorer watch/reveal, source-control local resets. Git provider compatibility required.            |
 | Settings                       | `components/settings/**`                                                                                 | Inventory complete, manual review in progress | Repository hook local editor visibility covered by #3093. Continue with draft mirrors while keeping SSH and cross-platform settings behavior intact. |
-| Automations                    | `components/automations/**`                                                                              | Inventory complete, manual review in progress | Combobox open-focus Effects covered by #3100. Continue with run-table selection repair, draft defaulting, polling, and completion detection. |
+| Automations                    | `components/automations/**`                                                                              | Inventory complete, manual review in progress | Combobox open-focus Effects covered by #3100; external run-table selection repair covered by #3102. Continue with draft defaulting, polling, and completion detection. |
 | Issue, PR, task pages          | `TaskPage.tsx`, `PullRequestPage.tsx`, `GitHubItemDialog.tsx`, `GitLabItemDialog.tsx`, Linear components | Inventory complete, manual review in progress | Large files with many Effects. Separate GitHub, GitLab, Linear, and generic review behavior.                                       |
 | Onboarding / feature wall      | `components/onboarding/**`, `components/feature-wall/**`                                                 | Inventory complete, manual review in progress | Select portal root Effects covered by #3087; tour visited-marker Effects covered by #3095. Continue with demo timers and telemetry while avoiding telemetry semantic changes. |
 | Status, dashboard, activity    | `components/status-bar/**`, `components/dashboard/**`, `components/activity/**`                          | Inventory complete, manual review in progress | Status-bar account menu close reset covered by #3051. Check interval sharing, retained agent state, activity terminal portals.      |
@@ -118,6 +118,7 @@ These are candidate batches, not final conclusions. Each item needs code inspect
 | PR AO        | Feature-wall tour visited markers                     | Four Effects marked visible workflows/substeps as visited after render instead of in the open/select/continue transitions. | `FeatureWallTourSurface.tsx` covered by #3095                                                                  | Medium         |
 | PR AP        | Editor copy feedback timers                           | Copy success indicators started their auto-clear timers in Effects after render rather than in the copy handlers. | `EditorPanel.tsx`, `MarkdownPreview.tsx` covered by #3097                                                      | Medium         |
 | PR AQ        | Combobox open focus                                   | Four comboboxes focused search inputs and seeded cmdk highlight state in Effects after opening.            | `AgentCombobox.tsx`, `RepoCombobox.tsx`, `WorkspaceCombobox.tsx`, `CreateFromPicker.tsx` covered by #3100       | Low            |
+| PR AR        | Automation run-table selection repair                 | External automation run selection was repaired in an Effect after the visible run page changed.             | `ExternalAutomationRunTable.tsx` covered by #3102                                                             | Medium         |

 ## Merge Risk Scale

@@ -166,6 +167,7 @@ These are candidate batches, not final conclusions. Each item needs code inspect
 | #3095 | `nwparker/react-perf-feature-wall-visited-events` | Feature-wall tour visited markers move from Effects to open/select/continue handlers | Medium | Open   | `pnpm exec oxlint src/renderer/src/components/feature-wall/FeatureWallTourSurface.tsx`; `pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/feature-wall/use-feature-wall-completion.test.ts src/renderer/src/components/feature-wall/use-feature-wall-tour-telemetry.test.ts`; `pnpm run typecheck:web`; `git diff --check`; AST Effect count 932 -> 928. |
 | #3097 | `nwparker/react-perf-editor-copy-timers` | Editor copy feedback clear timers move into the copy handlers | Medium | Open   | `pnpm exec oxlint src/renderer/src/components/editor/MarkdownPreview.tsx src/renderer/src/components/editor/EditorPanel.tsx`; `pnpm run typecheck:web`; `git diff --check`; AST Effect count 932 -> 930. |
 | #3100 | `nwparker/react-perf-combobox-open-focus` | Combobox open focus and cmdk highlight seeding move out of Effects | Low | Merged | `pnpm exec oxlint src/renderer/src/components/agent/AgentCombobox.tsx src/renderer/src/components/repo/RepoCombobox.tsx src/renderer/src/components/automations/WorkspaceCombobox.tsx src/renderer/src/components/automations/CreateFromPicker.tsx`; `pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/agent/AgentCombobox.test.tsx`; `pnpm run typecheck:web`; `git diff --check`; AST Effect count 932 -> 928. |
+| #3102 | `nwparker/react-perf-automation-run-selection` | External automation run-table selection repair moves into page navigation/render derivation | Medium | Open   | `pnpm exec oxlint src/renderer/src/components/automations/ExternalAutomationRunTable.tsx`; `pnpm run typecheck:web`; `git diff --check`; AST Effect count 928 -> 927. |

 ## Reproduction Commands