starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-22 00:02:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Windows release publish command (#2905)

Browse Source
This commit is contained in:
Brennan Benson
2026-05-27 01:12:51 -07:00
committed by GitHub
parent 48a1923756
commit 2541f64dc6
2 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/release-cut.yml
+1 -1
View File
@@ -467,7 +467,7 @@ jobs:
~/Library/Caches/electron-builder
- os: windows-latest
platform: win
release_command: node config/scripts/ensure-native-runtime.mjs --runtime=electron && pnpm exec electron-builder --config config/electron-builder.config.cjs --win --publish always
release_command: 'node config/scripts/ensure-native-runtime.mjs --runtime=electron; if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }; pnpm exec electron-builder --config config/electron-builder.config.cjs --win --publish always'
eb_cache_path: |
~\AppData\Local\electron\Cache
~\AppData\Local\electron-builder\Cache
config/scripts/package-electron-runtime-contract.test.mjs
+16 -5
View File
@@ -2,6 +2,7 @@ import { readFileSync } from 'node:fs'
import { dirname, join, resolve } from 'node:path'
import { fileURLToPath } from 'node:url'
import { describe, expect, it } from 'vitest'
import { parse } from 'yaml'
const projectDir = resolve(dirname(fileURLToPath(import.meta.url)), '../..')
const packageJson = JSON.parse(readFileSync(join(projectDir, 'package.json'), 'utf8'))
@@ -34,14 +35,24 @@ describe('Electron runtime package contract', () => {
it('guards release publishing before electron-builder runs', () => {
const releaseWorkflow = readFileSync(join(projectDir, '.github/workflows/release-cut.yml'), 'utf8')
const releaseCommands = [...releaseWorkflow.matchAll(/release_command:\s*(.+)/g)].map(
([, command]) => command
const parsedWorkflow = parse(releaseWorkflow)
const releaseCommands = new Map(
parsedWorkflow.jobs.build.strategy.matrix.include.map(({ platform, release_command }) => [
platform,
release_command
])
)
expect(releaseCommands).toHaveLength(3)
for (const command of releaseCommands) {
expect(command).toMatch(/^node config\/scripts\/ensure-native-runtime\.mjs --runtime=electron && /)
expect([...releaseCommands.keys()].sort()).toEqual(['linux', 'mac', 'win'])
for (const command of releaseCommands.values()) {
expect(command).toContain('node config/scripts/ensure-native-runtime.mjs --runtime=electron')
expect(command).toContain('electron-builder')
expect(command.indexOf('ensure-native-runtime')).toBeLessThan(command.indexOf('electron-builder'))
}
expect(releaseCommands.get('mac')).toContain(' && ORCA_MAC_RELEASE=1 ')
expect(releaseCommands.get('linux')).toContain(' && pnpm exec electron-builder ')
expect(releaseCommands.get('win')).toContain(
'; if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }; pnpm exec electron-builder '
)
})
})