fix(cloud): agent-row sign-in tooltip names Orca Cloud, not Settings (it opens the JA-04 sheet)

'Set up once in Settings → Agent accounts' / 'Renew in Settings → Agent accounts' become
'Set up once for Orca Cloud' / 'Renew once for Orca Cloud', matching the strip.
This commit is contained in:
Neil
2026-11-11 00:37:51 -08:00
parent 6c76b1e5e8
commit 37f2995d58
3 changed files with 8 additions and 8 deletions
@@ -407,7 +407,7 @@ function focusTooltip(button: HTMLButtonElement): Element | null {
describe.each([
['compact', renderRow],
['full', renderFullRow]
] as const)('%s row: the sign-in status links to Settings → Agent accounts', (_name, render) => {
] as const)('%s row: the sign-in status opens the Orca Cloud sign-in sheet', (_name, render) => {
beforeEach(() => {
useAppStore.setState({ activeView: 'terminal', settingsNavigationTarget: null })
})
@@ -421,7 +421,7 @@ describe.each([
it('shows the app tooltip below and from the start on keyboard focus, clear of the name above', () => {
const [, text] = statusButtons(render(makeAgent(CLOUD_WORKTREE, true)))
expect(focusTooltip(text)?.textContent).toBe('Set up once in Settings → Agent accounts')
expect(focusTooltip(text)?.textContent).toBe('Set up once for Orca Cloud')
const content = document.body.querySelector('[data-side]')
expect(content?.getAttribute('data-side')).toBe('bottom')
expect(content?.getAttribute('data-align')).toBe('start')
@@ -429,13 +429,13 @@ describe.each([
it('shows the app tooltip on keyboard focus of the dot', () => {
const [dot] = statusButtons(render(makeAgent(CLOUD_WORKTREE, true)))
expect(focusTooltip(dot)?.textContent).toBe('Set up once in Settings → Agent accounts')
expect(focusTooltip(dot)?.textContent).toBe('Set up once for Orca Cloud')
})
it('tells an expired sign-in to renew', () => {
setOrcaCloudAgentAccountsStateForTest(accounts({ state: 'expired' }))
const [, text] = statusButtons(render(makeAgent(CLOUD_WORKTREE, true)))
expect(focusTooltip(text)?.textContent).toBe('Renew in Settings → Agent accounts')
expect(focusTooltip(text)?.textContent).toBe('Renew once for Orca Cloud')
})
// JA-04 (#349): "Set up once" opens the focused "Agents in Orca Cloud" sheet, not Settings.
+2 -2
View File
@@ -28115,9 +28115,9 @@
},
"agentSignInStrip": {
"rowNeedsSignIn": "Needs sign-in",
"rowNeedsSignInTooltip": "Set up once in Settings → Agent accounts",
"rowNeedsSignInTooltip": "Set up once for Orca Cloud",
"rowExpired": "Sign-in expired",
"rowExpiredTooltip": "Renew in Settings → Agent accounts",
"rowExpiredTooltip": "Renew once for Orca Cloud",
"sandbox": "the sandbox",
"queued": "Queued prompt: {{prompt}}",
"pasteLabel": "Code from claude.ai",
@@ -87,6 +87,6 @@ export function cloudAgentRowSignInLabel(signIn: CloudAgentRowSignIn, t: Transla
/** Where the fix lives; the row's status opens it (Settings → Agent accounts). */
export function cloudAgentRowSignInTooltip(signIn: CloudAgentRowSignIn, t: Translate): string {
return signIn === 'expired'
? t('agentSignInStrip.rowExpiredTooltip', 'Renew in Settings → Agent accounts')
: t('agentSignInStrip.rowNeedsSignInTooltip', 'Set up once in Settings → Agent accounts')
? t('agentSignInStrip.rowExpiredTooltip', 'Renew once for Orca Cloud')
: t('agentSignInStrip.rowNeedsSignInTooltip', 'Set up once for Orca Cloud')
}