starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-24 00:04:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(cleanup): read the host's process evidence, not its legacy collapse

Browse Source 
A host that answered but whose probes failed publishes the deliberate legacy
collapse (foregroundProcess = the stable-cache shell name, hasChildProcesses =
false) with the real verdict in processEvidence. That legacy half is
byte-identical to an idle shell, so cleanup dropped the blocker and select-all
swept the row. unavailable only ever covered a handle we could not route to.

Old hosts keep their old meaning: readPtyProcessInspectionEvidence falls back to
the legacy interpretation when the field is absent.
This commit is contained in:
Brennan Benson
2026-08-28 08:38:49 -07:00
parent bef74dac25
commit 382dfa427b
1 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/store/slices/workspace-cleanup-local-evidence.ts
+19 -2
View File
@@ -7,6 +7,7 @@ import { classifyTitleActivity, isExplicitAgentStatusFresh } from '@/lib/pane-ag
import type { WorkspaceCleanupCandidate } from '../../../../shared/workspace-cleanup'
import { getWorktreeVisitTimestamp } from '@/lib/worktree-visit-recency'
import { inspectRuntimeTerminalProcess } from '@/runtime/runtime-terminal-process-inspection'
import { readPtyProcessInspectionEvidence } from '../../../../shared/pty-process-inspection-evidence'
const RECENT_VISIBLE_CONTEXT_MS = 24 * 60 * 60 * 1000
const VIEWED_FROM_CLEANUP_MS = 2 * 60 * 60 * 1000
@@ -179,8 +180,24 @@ export async function probeTerminalLiveness(
unverifiable = true
continue
}
const processName = normalizeProcessName(inspection.foregroundProcess)
if (!inspection.hasChildProcesses && (!processName || SHELL_PROCESS_NAMES.has(processName))) {
// Why the evidence and not the legacy fields: `unavailable` only covers a
// handle we could not route to. A host that DID answer but whose probes
// failed publishes the legacy collapse (null/false, or the shell name from
// the stable cache) — byte-identical to an idle shell. Only processEvidence
// separates "observed idle" from "could not ask", and this is a delete path.
const evidence = readPtyProcessInspectionEvidence(inspection)
if (
evidence.foreground.verdict === 'unverifiable' ||
evidence.children.verdict === 'unverifiable'
) {
unverifiable = true
continue
}
const processName = normalizeProcessName(evidence.foreground.processName)
if (
evidence.children.verdict !== 'live' &&
(!processName || SHELL_PROCESS_NAMES.has(processName))
) {
continue
}
if (