refactor(renderer): place remaining library features with their owners

This commit is contained in:
Neil
2026-11-10 21:27:51 -08:00
parent 5401c07619
commit 39a2b2a8f7
64 changed files with 108 additions and 101 deletions
@@ -1,7 +1,7 @@
import { canShowRightSidebarForView } from '@/components/right-sidebar/visibility/right-sidebar-visibility'
import { runBuiltInOrReplacement } from '@/lib/plugins/commands/plugin-command-replacements'
import { isFloatingWorkspacePanelFocused } from '@/components/floating-terminal/floating-workspace-terminal-actions'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { requestScrollToCurrentWorkspaceRevealAndRename } from '@/lib/workspace/navigation/scroll-to-current-workspace-status'
import { requestVirtualizedScrollAnchorRecord } from '@/hooks/requestVirtualizedScrollAnchorRecord'
import { showTerminalShortcutCaptureNotification } from '@/lib/notifications/terminal-shortcut-capture-notification'
@@ -4,7 +4,7 @@ import { getIndexedRepoMap } from '@/store/repos/repository-catalog-index'
import type { AppState } from '@/store/types'
import { getSettingsFocusedExecutionHostId } from '../../../../shared/execution-host'
import type { Worktree } from '../../../../shared/worktree/types'
import { sameBucketRecords } from '../../lib/bucket-record-equality'
import { sameBucketRecords } from './unread-bucket-record-equality'
import { getUnreadBadgeCount } from './unread-badge-count'
import { hasLiveTabMarker } from '@/store/slices/workspace-attention/workspace-live-markers'
import { folderWorkspaceKey } from '../../../../shared/workspace-scope'
@@ -3,7 +3,7 @@ import '../assets/main.css'
import ReactDOM from 'react-dom/client'
import { getDefaultSettings } from '../../../shared/constants'
import { applyDocumentTheme } from '../app-shell/appearance/document-theme'
import { installBodyOverlayAttributes } from '../lib/body-overlay-attributes'
import { installBodyOverlayAttributes } from '../lib/overlay-interaction/body-overlay-attributes'
import { useAppStore } from '../store/index'
import { installWebPreloadApi } from '../web/web-preload-api'
import type { ComponentFixtureTheme } from './component-fixture'
@@ -1,5 +1,5 @@
import { useEffect } from 'react'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import type { AutomationsPageLocalState } from './use-automations-page-local-state'
import type { AutomationsPageStoreState } from './use-automations-page-store-state'
import { addAppKeyListener, removeAppKeyListener } from '@/lib/keyboard/app-keyboard-router'
@@ -12,7 +12,7 @@ import {
} from '@/components/ui/dialog'
import { translate } from '@/i18n/i18n'
import { useTranslate, type Translate } from '@/i18n/use-translate'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
import { useAppStore } from '@/store'
import type { BrowserExtensionInstallPromptRequest } from '../../../shared/browser/extensions/browser-extension-webstore'
import {
@@ -11,7 +11,7 @@ import {
import { BrowserCookieImportDisclosure } from '@/components/BrowserCookieImportDisclosure'
import { BrowserCookieImportMachineNotice } from '@/components/BrowserCookieImportMachineNotice'
import { useTranslate } from '@/i18n/use-translate'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
import { BROWSER_FAMILY_LABELS } from '../../../../../shared/browser/browser-family-labels'
import type { BrowserSessionProfile } from '../../../../../shared/browser-workspace-types'
@@ -1,5 +1,5 @@
import { useEffect, useState } from 'react'
import { hasVisibleOverlayOver } from '@/lib/visible-overlay'
import { hasVisibleOverlayOver } from '@/lib/overlay-interaction/visible-overlay'
import { registerBrowserClientPagePositionSync } from '../browser-client-page-position-driver'
import {
isWebviewDragPassthroughActive,
@@ -29,7 +29,7 @@ import {
} from './contextual-tour-floating-position'
import { useTranslate } from '@/i18n/use-translate'
import { addAppKeyListener, removeAppKeyListener } from '@/lib/keyboard/app-keyboard-router'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { getMeasurableContextualTourTarget } from './contextual-tour-gate'
const FOCUSABLE_SELECTOR =
@@ -1,4 +1,4 @@
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { hasContextualTourActionStep } from '../../../../shared/contextual-tour-action-steps'
import { useEffect, useRef, type RefObject } from 'react'
import { getContextualTour, type ContextualTourId } from '../../../../shared/contextual-tours'
@@ -8,7 +8,7 @@ import {
} from '@/hooks/skills/discovery/useInstalledAgentSkills'
import { useMountedRef } from '@/hooks/useMountedRef'
import { translate } from '@/i18n/i18n'
import { formatCliUserFacingDetail } from '@/lib/cli-emulator-user-facing-copy'
import { formatCliUserFacingDetail } from '@/lib/cli/cli-user-facing-detail'
// Why: Orca terminals already provide the `orca` command, so agent control only needs the skill.
export function useMobileEmulatorAgentSetupState(enabled = true): {
@@ -27,7 +27,7 @@ import {
import { useMountedRef } from '@/hooks/useMountedRef'
import { isWebClientLocation } from '@/app-shell/platform/web-client-location'
import { useTranslate } from '@/i18n/use-translate'
import { formatCliUserFacingDetail } from '@/lib/cli-emulator-user-facing-copy'
import { formatCliUserFacingDetail } from '@/lib/cli/cli-user-facing-detail'
import { SessionSearchTipDialog } from './SessionSearchTipDialog'
import { useSessionSearchTipSetup } from './use-session-search-tip-setup'
import { VoiceDictationTipDialog } from './VoiceDictationTipDialog'
@@ -17,7 +17,7 @@ import { Label } from '@/components/ui/label'
import { ToggleGroup, ToggleGroupItem } from '@/components/ui/toggle-group'
import { cn } from '@/lib/class-names'
import { hasRemoteProviderRuntime } from '@/runtime/hosts/observations/provider-runtime-context'
import { preventOutsideDismissWhenDirty } from '@/lib/outside-dismiss-guard'
import { preventOutsideDismissWhenDirty } from '@/lib/overlay-interaction/outside-dismiss-guard'
import { bitbucketConnectErrorText } from '@/lib/source-control/remote/bitbucket-connect-error-copy'
import { useTranslate } from '@/i18n/use-translate'
import { BitbucketApiTokenScopes } from './bitbucket-api-token-scopes'
@@ -24,7 +24,7 @@ import {
getProviderRuntimeContextKey,
isEnvironmentRuntimeContextKey
} from '@/runtime/hosts/observations/provider-runtime-context'
import { preventOutsideDismissWhenDirty } from '@/lib/outside-dismiss-guard'
import { preventOutsideDismissWhenDirty } from '@/lib/overlay-interaction/outside-dismiss-guard'
import { useTranslate } from '@/i18n/use-translate'
import { JiraConnectCredentialGuide } from './jira-connect-credential-guide'
@@ -24,7 +24,7 @@ import {
import { Input } from '@/components/ui/input'
import { Label } from '@/components/ui/label'
import { cn } from '@/lib/class-names'
import { preventOutsideDismissWhenDirty } from '@/lib/outside-dismiss-guard'
import { preventOutsideDismissWhenDirty } from '@/lib/overlay-interaction/outside-dismiss-guard'
import {
createLinearApiKeyDialogState,
resolveLinearApiKeyDialogState
@@ -8,7 +8,9 @@ import type { NativeChatComposerHandle } from '../native-chat-composer-types'
import { useNativeChatRootInputRouting } from './use-native-chat-root-input-routing'
const overlay = vi.hoisted(() => ({ visible: false }))
vi.mock('@/lib/visible-overlay', () => ({ hasVisibleOverlay: () => overlay.visible }))
vi.mock('@/lib/overlay-interaction/visible-overlay', () => ({
hasVisibleOverlay: () => overlay.visible
}))
const insertTypedText = vi.fn(() => true)
const composer: NativeChatComposerHandle = {
@@ -6,7 +6,7 @@ import {
type PointerEvent as ReactPointerEvent,
type RefObject
} from 'react'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { DICTATION_FOCUS_INPUT_EVENT } from '../../../dictation/dictation-control-events'
import { routeNativeChatRootKeyToInput } from './native-chat-root-key-routing'
import { shouldFocusNativeChatPaneFromPointerTarget } from './native-chat-typing-redirect'
@@ -14,7 +14,7 @@ import type { RuntimeClientTarget } from '../../../../shared/runtime-client-targ
import { useOrchestrationCrew } from './use-orchestration-crew'
import { translate } from '@/i18n/i18n'
import { useTranslate, type Translate } from '@/i18n/use-translate'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { isImeOwnedKeyboardEvent } from '@/lib/text-input/ime/ime-composition-keyboard-event'
import { CrewRowView, IconButton } from './CrewRowView'
import {
@@ -41,7 +41,7 @@ import { isMacUserAgent } from '@/app-shell/platform/user-agent-platform'
import { isWebClientLocation } from '@/app-shell/platform/web-client-location'
import { useTranslate } from '@/i18n/use-translate'
import { translateHostDisplayLabel } from '../../sidebar/execution-host-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
import { useUiLanguageRevision } from '@/i18n/use-ui-language-revision'
import { resolveAvailableBrowserSessionHostId } from './profiles/browser-session-host-selection'
import { getDefaultBrowserProfileForHost } from '@/store/slices/browser/hosts/browser-host-state'
@@ -19,7 +19,7 @@ import { getBrowserSitePermissionsSearchEntry } from './browser-site-permissions
import { LOCAL_EXECUTION_HOST_ID } from '../../../../../shared/execution-host'
import { useAppStore } from '../../../store/index'
import { useTranslate } from '@/i18n/use-translate'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
function SitePermissionRow({
entry,
@@ -24,7 +24,7 @@ import '../../../../../../shared/constants'
import { BROWSER_FAMILY_LABELS } from '../../../../../../shared/browser/browser-family-labels'
import { useTranslate } from '@/i18n/use-translate'
import { browserCookieImportFailureText } from '@/lib/browser/cookies/browser-cookie-import-error-copy'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
type DetectedBrowser = {
family: string
@@ -26,7 +26,7 @@ import { useCliRegistrationActions } from './use-cli-registration-actions'
import { useLocalCliSkillFreshnessName } from '../../../../hooks/skills/freshness/use-local-cli-skill-freshness-name'
import { translate } from '@/i18n/i18n'
import { useTranslate, type Translate } from '@/i18n/use-translate'
import { formatCliUserFacingDetail } from '@/lib/cli-emulator-user-facing-copy'
import { formatCliUserFacingDetail } from '@/lib/cli/cli-user-facing-detail'
type CliSectionProps = {
currentPlatform: string
@@ -18,7 +18,7 @@ import { Switch } from '../../../ui/switch'
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '../../../ui/tooltip'
import { translate } from '@/i18n/i18n'
import { useTranslate } from '@/i18n/use-translate'
import { formatCliUserFacingDetail } from '@/lib/cli-emulator-user-facing-copy'
import { formatCliUserFacingDetail } from '@/lib/cli/cli-user-facing-detail'
type WslCliRegistrationProps = {
currentPlatform: string
@@ -1,5 +1,5 @@
import type { CliInstallStatus } from '../../../../../../shared/cli-install-types'
import { formatCliUserFacingDetail } from '@/lib/cli-emulator-user-facing-copy'
import { formatCliUserFacingDetail } from '@/lib/cli/cli-user-facing-detail'
// Why: Electron re-wraps a rejected `ipcMain.handle` as
// `Error invoking remote method '<channel>': Error: <message>`, so the installer's
@@ -7,7 +7,7 @@ import { resolveAppearanceAccordionDeepLink } from '../appearance/appearance-usa
import { registerWindowCloseGuard } from '../../window-close-request-coordinator'
import { isIntentionalAppRestartInProgress } from '@/app-shell/updates/updater-beforeunload'
import { getShortcutPlatform } from '@/lib/keyboard/shortcut-platform'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { translate } from '@/i18n/i18n'
import {
getSettingsTargetHostSelection,
@@ -5,7 +5,7 @@ import type { Project, ProjectUpdateArgs } from '../../../../../shared/project-t
import type { Repo } from '../../../../../shared/repo-types'
import type { SourceControlAiSettingsPatch } from '../../../../../shared/source-control/ai/settings/source-control-ai-settings-types'
import { getRepoKindLabel, isFolderRepo } from '../../../../../shared/repo-kind'
import { useFolderSetupSupport } from '@/lib/use-folder-setup-supported'
import { useFolderSetupSupport } from '@/lib/workspace/creation/setup/folder-setup-support'
import { getRepoExecutionHostId, type ExecutionHostId } from '../../../../../shared/execution-host'
import { Label } from '../../ui/label'
import { useShallow } from 'zustand/react/shallow'
@@ -19,7 +19,7 @@ import {
type EditingTarget
} from '../../../ssh-host-form/ssh-target-draft'
import { useTranslate } from '@/i18n/use-translate'
import { preventOutsideDismissWhenDirty } from '@/lib/outside-dismiss-guard'
import { preventOutsideDismissWhenDirty } from '@/lib/overlay-interaction/outside-dismiss-guard'
type SshTargetFormProps = {
open: boolean
@@ -1,5 +1,5 @@
import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { applySshTargetSelectionClick } from './ssh-target-list-model'
export type SshTargetSelection = {
@@ -1,6 +1,6 @@
import type { ReactNode } from 'react'
import { Dialog, DialogContent } from '@/components/ui/dialog'
import { preventOutsideDismissWhenDirty } from '@/lib/outside-dismiss-guard'
import { preventOutsideDismissWhenDirty } from '@/lib/overlay-interaction/outside-dismiss-guard'
import type { AddRepoDialogStep } from './add-repo-dialog-types'
import { AddRepoStepIndicator } from './AddRepoStepIndicator'
@@ -3,7 +3,7 @@ import { useAppStore } from '@/store'
import { resolveQualifiedWorktreeExecutionOwner } from '@/lib/workspace/ownership/qualified-worktree-execution-owner'
import { resolveQualifiedIndexedFolderWorkspace } from '@/store/folder-workspaces/folder-workspace-record-index'
import { selectWorktreeCreationSurfaceShown } from '@/lib/workspace/creation/worktree-creation-surface'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import type { AppState } from '@/store/types'
import { isEditableTarget, isNativeChatPromptTarget } from '@/lib/text-input/focus/editable-target'
import { composeWorktreeHostIdentity } from '../../../../../../shared/worktree/host-qualified-identity'
@@ -3,7 +3,7 @@ import { useAppStore } from '@/store/index'
import { addAppKeyListener, removeAppKeyListener } from '@/lib/keyboard/app-keyboard-router'
import { textFieldClaimsActionKey } from '@/lib/keyboard/text-field-shortcut-policy'
import { getShortcutPlatform } from '@/lib/keyboard/shortcut-platform'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { showTerminalShortcutCaptureNotification } from '@/lib/notifications/terminal-shortcut-capture-notification'
import { keybindingMatchesAction } from '../../../../../../shared/keybindings'
import {
@@ -4,7 +4,7 @@ import type React from 'react'
import { useAppStore } from '@/store'
import { activateWorktreeFromSidebar } from '@/lib/workspace/activation/sidebar-worktree-activation'
import { focusRuntimeTerminalSurface } from '@/runtime/hosted-terminals/mounted-surfaces/mounted-terminal-tab-registry'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import type { ExecutionHostId } from '../../../../../../shared/execution-host'
import { getShortcutPlatform } from '@/lib/keyboard/shortcut-platform'
import { keybindingMatchesAction } from '../../../../../../shared/keybindings'
@@ -1,6 +1,6 @@
import { useEffect } from 'react'
import type { SkillsPageView } from './skills-page-view'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { addAppKeyListener, removeAppKeyListener } from '@/lib/keyboard/app-keyboard-router'
type UseSkillsPageKeyboardNavigationOptions = {
@@ -1,7 +1,7 @@
import type { ProviderRateLimits } from '../../../../shared/rate-limit-types'
import { translate } from '@/i18n/i18n'
import type { Translate } from '@/i18n/use-translate'
import { formatRateLimitUserFacingError } from '@/lib/rate-limit-user-facing-error'
import { formatRateLimitUserFacingError } from '@/components/status-bar/usage-errors/rate-limit-user-facing-error'
import { getProviderDisplayName } from '../../../../shared/usage-provider-windows'
import { describeOwnerNotSetUp, getOwnerNotSetUpLabel } from './owner-not-set-up-copy'
@@ -2,7 +2,7 @@ import { useCallback, useEffect, useRef, type KeyboardEvent } from 'react'
import { isImeCompositionKeyDown } from '@/lib/text-input/ime/ime-composition-keyboard-event'
import { requestNativeChatComposerFocus } from '@/components/native-chat/composer/focus/native-chat-composer-focus-intent'
import { focusTerminalTabSurface } from '@/components/terminal-pane/input/focus/focus-terminal-tab-surface'
import { hasVisibleOverlay } from '@/lib/visible-overlay'
import { hasVisibleOverlay } from '@/lib/overlay-interaction/visible-overlay'
import { useAppStore } from '@/store'
export function useTabRenameReturnFocus({
@@ -1,4 +1,4 @@
import { flattenRetainedSlice } from '../../../lib/flatten-retained-slice'
import { flattenRetainedSlice } from '../../../lib/terminal/output/flatten-retained-slice'
import { isTerminalResourceLimitError } from '../../../../../shared/terminal/pty/lifecycle/terminal-spawn-resource-error'
// Legacy tab messages render as newline-joined text and need whole-run dedup; pane errors stay separate until render.
@@ -1,5 +1,5 @@
import type { PtyDataMeta } from '../../pty-transport/delivery/pty-dispatcher'
import { flattenRetainedSlice } from '../../../../lib/flatten-retained-slice'
import { flattenRetainedSlice } from '../../../../lib/terminal/output/flatten-retained-slice'
import {
keptSuffixMeta,
markedAfterEviction
@@ -1,5 +1,5 @@
import { clampUtf8TextTail } from '../../../../../../shared/utf8-byte-limits'
import { flattenRetainedSlice } from '../../../../lib/flatten-retained-slice'
import { flattenRetainedSlice } from '../../../../lib/terminal/output/flatten-retained-slice'
export type EagerBufferChunk = {
data: string
+1 -1
View File
@@ -8,7 +8,7 @@ import {
import { useRef, type SyntheticEvent } from 'react'
import { Toaster as Sonner, type ToasterProps } from 'sonner'
import { useAppStore } from '@/store/index'
import { MODAL_OVERLAY_CHILD_SELECTOR } from '@/lib/body-overlay-attributes'
import { MODAL_OVERLAY_CHILD_SELECTOR } from '@/lib/overlay-interaction/body-overlay-attributes'
import {
NOTIFICATION_CARD_STACK_BOTTOM,
NOTIFICATION_CARD_STACK_HEIGHT_VAR
@@ -9,7 +9,7 @@ import {
confirmAndClearGoogleCookies
} from '@/lib/browser/cookies/browser-google-cookie-clear'
import { useTranslate } from '@/i18n/use-translate'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
import { getRuntimeEnvironmentRevision } from '@/runtime/rpc/environment-revisions/runtime-environment-revision'
export function useGoogleCookieClear(hostId: ExecutionHostId, profileId: string, label?: string) {
@@ -1,4 +1,4 @@
import { useFolderSetupSupport } from '@/lib/use-folder-setup-supported'
import { useFolderSetupSupport } from '@/lib/workspace/creation/setup/folder-setup-support'
import type { DerivedComposerStateInput } from './composer-target-input-contracts'
import { useMemo } from 'react'
@@ -1,4 +1,4 @@
import type { FolderSetupSupport } from '@/lib/use-folder-setup-supported'
import type { FolderSetupSupport } from '@/lib/workspace/creation/setup/folder-setup-support'
import type { GitHubWorkItem } from '../../../../shared/github/work-item-types'
import type { OrcaHooks, SetupRunPolicy } from '../../../../shared/orca-yaml-hook-types'
import type { SparsePreset } from '../../../../shared/worktree/create-types'
@@ -13,7 +13,7 @@ import {
import type { SetupDecision } from '../../../../shared/worktree/create-types'
import type { WorktreeCreationRequest } from '@/lib/workspace/creation/pending-worktree-creation'
import { resolveComposerBranchNameOverrideForCreate } from '../composer-branch-selection'
import { resolveFolderSetupSupported } from '@/lib/use-folder-setup-supported'
import { resolveFolderSetupSupported } from '@/lib/workspace/creation/setup/folder-setup-support'
import { translate } from '@/i18n/i18n'
import { resolveWorktreeCreateBaseBranch } from '@/runtime/source-control/worktree-creation/worktree-create-base'
import type { TuiAgent } from '../../../../shared/agent-launch/catalog/tui-agent'
@@ -9,7 +9,7 @@ import { callRuntimeRpc } from '@/runtime/rpc/calls/runtime-rpc-call'
import { useAppStore } from '@/store/index'
import { parseExecutionHostId, type ExecutionHostId } from '../../../../../shared/execution-host'
import { translate } from '@/i18n/i18n'
import { translateBrowserSessionProfileLabel } from '@/lib/browser-session-profile-label'
import { translateBrowserSessionProfileLabel } from '@/lib/browser/profiles/browser-session-profile-label'
import { getRuntimeEnvironmentRevision } from '@/runtime/rpc/environment-revisions/runtime-environment-revision'
function remoteGoogleCookieClearAvailable(environmentId: string): boolean {
@@ -132,23 +132,6 @@ const KNOWN_CLI_DETAILS: {
}
]
const KNOWN_ANDROID_MESSAGES: { test: string; key: string; fallback: string }[] = [
{
test: 'Android SDK not found. Install Android Studio and set ANDROID_HOME.',
key: 'auto.lib.emulator.androidSdkNotFound',
fallback: 'Android SDK not found. Install Android Studio and set ANDROID_HOME.'
}
]
const KNOWN_IOS_MESSAGES: { test: string; key: string; fallback: string }[] = [
{
test: 'Xcode Simulator tools are unavailable. Install full Xcode, open it once, then select it with `sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer`.',
key: 'auto.lib.emulator.xcodeSimulatorToolsUnavailable',
fallback:
'Xcode Simulator tools are unavailable. Install full Xcode, open it once, then select it with `sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer`.'
}
]
function stripElectronInvokePrefix(raw: string): string {
const match = raw.match(/Error invoking remote method '[^']+': Error:\s*(.+)$/s)
return match?.[1]?.trim() || raw
@@ -214,33 +197,3 @@ export function formatCliUserFacingDetail(raw: string | null | undefined): strin
}
return normalized
}
export function formatEmulatorAvailabilityUserFacingMessage(
raw: string | null | undefined
): string {
if (!raw?.trim()) {
return ''
}
for (const known of KNOWN_IOS_MESSAGES) {
if (raw === known.test || raw.includes(known.test)) {
return translate(known.key, known.fallback)
}
}
const android = formatAndroidSdkUserFacingMessage(raw)
if (android !== raw) {
return android
}
return formatCliUserFacingDetail(raw)
}
export function formatAndroidSdkUserFacingMessage(raw: string | null | undefined): string {
if (!raw?.trim()) {
return ''
}
for (const known of KNOWN_ANDROID_MESSAGES) {
if (raw === known.test || raw.includes(known.test)) {
return translate(known.key, known.fallback)
}
}
return raw
}
@@ -1,4 +1,4 @@
import { getVisibleOverlays, isVisibleOverlay } from '../visible-overlay'
import { getVisibleOverlays, isVisibleOverlay } from './visible-overlay'
const NON_OWNING_SURFACES =
'[data-focus-behavior="page"], [data-focus-behavior="composer-suggestions"]'
@@ -1,4 +1,4 @@
import { flattenRetainedSlice } from '@/lib/flatten-retained-slice'
import { flattenRetainedSlice } from '@/lib/terminal/output/flatten-retained-slice'
import { resolveSynchronizedOutputSafeSplit } from '../../../../../shared/terminal/protocol/escape/terminal-synchronized-output-scan'
import type {
QueueEntry,
@@ -0,0 +1,49 @@
import { translate } from '@/i18n/i18n'
import { formatCliUserFacingDetail } from '../cli/cli-user-facing-detail'
const KNOWN_ANDROID_MESSAGES: { test: string; key: string; fallback: string }[] = [
{
test: 'Android SDK not found. Install Android Studio and set ANDROID_HOME.',
key: 'auto.lib.emulator.androidSdkNotFound',
fallback: 'Android SDK not found. Install Android Studio and set ANDROID_HOME.'
}
]
const KNOWN_IOS_MESSAGES: { test: string; key: string; fallback: string }[] = [
{
test: 'Xcode Simulator tools are unavailable. Install full Xcode, open it once, then select it with `sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer`.',
key: 'auto.lib.emulator.xcodeSimulatorToolsUnavailable',
fallback:
'Xcode Simulator tools are unavailable. Install full Xcode, open it once, then select it with `sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer`.'
}
]
export function formatEmulatorAvailabilityUserFacingMessage(
raw: string | null | undefined
): string {
if (!raw?.trim()) {
return ''
}
for (const known of KNOWN_IOS_MESSAGES) {
if (raw === known.test || raw.includes(known.test)) {
return translate(known.key, known.fallback)
}
}
const android = formatAndroidSdkUserFacingMessage(raw)
if (android !== raw) {
return android
}
return formatCliUserFacingDetail(raw)
}
export function formatAndroidSdkUserFacingMessage(raw: string | null | undefined): string {
if (!raw?.trim()) {
return ''
}
for (const known of KNOWN_ANDROID_MESSAGES) {
if (raw === known.test || raw.includes(known.test)) {
return translate(known.key, known.fallback)
}
}
return raw
}
@@ -1,7 +1,7 @@
import { toast } from 'sonner'
import type { CliInstallStatus } from '../../../../../shared/cli-install-types'
import { translate } from '@/i18n/i18n'
import { formatCliUserFacingDetail } from '@/lib/cli-emulator-user-facing-copy'
import { formatCliUserFacingDetail } from '@/lib/cli/cli-user-facing-detail'
type EnsureOrcaCliAvailableOptions = {
onStatusChange?: (status: CliInstallStatus) => void
@@ -1,8 +1,11 @@
import { useCallback, useEffect, useSyncExternalStore } from 'react'
import { getRepoExecutionHostId, parseExecutionHostId } from '../../../shared/execution-host'
import { isFolderRepo } from '../../../shared/repo-kind'
import type { Repo } from '../../../shared/repo-types'
import { WORKTREE_FOLDER_SETUP_RUNTIME_CAPABILITY } from '../../../shared/worktree-runtime-capabilities'
import {
getRepoExecutionHostId,
parseExecutionHostId
} from '../../../../../../shared/execution-host'
import { isFolderRepo } from '../../../../../../shared/repo-kind'
import type { Repo } from '../../../../../../shared/repo-types'
import { WORKTREE_FOLDER_SETUP_RUNTIME_CAPABILITY } from '../../../../../../shared/worktree-runtime-capabilities'
import { runtimeEnvironmentSupportsCapability } from '@/runtime/rpc/compatibility/runtime-capability-proof'
export type FolderSetupSupport = 'supported' | 'unsupported' | 'pending'
+1 -1
View File
@@ -28,7 +28,7 @@ import { installBrowserClientPageRenderer } from './components/browser-pane/brow
import { registerBrowserClientPageGuestMessageHandler } from './components/browser-pane/browser-client-page-retained-elements'
import { handleGuestWindowCloseMessage } from './components/browser-pane/host-guest/browser-page-window-close'
import { installOsFileDropCancellationGuard } from './lib/files/drop/os-file-drop-cancellation-guard'
import { installBodyOverlayAttributes } from './lib/body-overlay-attributes'
import { installBodyOverlayAttributes } from './lib/overlay-interaction/body-overlay-attributes'
import { applyWindowMaterialToDocument } from './app-shell/appearance/window-material-runtime'
const disposeOsFileDropGuard = installOsFileDropCancellationGuard()
+1 -1
View File
@@ -19,7 +19,7 @@ import type { GlobalSettings } from '../../shared/global-settings-types'
import { getOrCreateRendererRoot } from './app-shell/startup/react-renderer-root'
import { setReactCommitCascadeRendererSurface } from './diagnostics/react-commits/react-commit-cascade-telemetry'
import { installOsFileDropCancellationGuard } from './lib/files/drop/os-file-drop-cancellation-guard'
import { installBodyOverlayAttributes } from './lib/body-overlay-attributes'
import { installBodyOverlayAttributes } from './lib/overlay-interaction/body-overlay-attributes'
import { useReduceVisualEffects } from './hooks/use-reduce-visual-effects'
const disposeOsFileDropGuard = installOsFileDropCancellationGuard()
+1 -1
View File
@@ -18,7 +18,7 @@ import { buildAppFontFamily } from './app-shell/appearance/app-font-family'
import { getOrCreateRendererRoot } from './app-shell/startup/react-renderer-root'
import { I18nProvider } from './i18n/I18nProvider'
import { useAppStore } from './store/index'
import { installBodyOverlayAttributes } from './lib/body-overlay-attributes'
import { installBodyOverlayAttributes } from './lib/overlay-interaction/body-overlay-attributes'
import { useReduceVisualEffects } from './hooks/use-reduce-visual-effects'
const disposeBodyOverlayAttributes = installBodyOverlayAttributes()
+1 -1
View File
@@ -22,7 +22,7 @@ import { WebPairingSecurityNotice } from './WebPairingSecurityNotice'
import { I18nProvider } from '../i18n/I18nProvider'
import { useTranslate } from '@/i18n/use-translate'
import { installOsFileDropCancellationGuard } from '../lib/files/drop/os-file-drop-cancellation-guard'
import { installBodyOverlayAttributes } from '../lib/body-overlay-attributes'
import { installBodyOverlayAttributes } from '../lib/overlay-interaction/body-overlay-attributes'
import { installAppKeyboardRouter } from '../lib/keyboard/app-keyboard-router'
const disposeOsFileDropGuard = installOsFileDropCancellationGuard()