fix(terminal): reduce inactive pane dimming

This commit is contained in:
Jinjing
2026-07-30 11:18:21 -07:00
parent bbb3e7e5ee
commit 39a992afc5
3 changed files with 11 additions and 2 deletions
@@ -1,4 +1,5 @@
import type { GlobalSettings } from '../../../../shared/types'
import { DEFAULT_TERMINAL_INACTIVE_PANE_OPACITY } from '../../../../shared/constants'
import { NumberField, SettingsSubsectionHeader } from './SettingsFormControls'
import { SearchableSetting } from './SearchableSetting'
import { clampNumber, resolvePaneStyleOptions } from '@/lib/terminal-theme'
@@ -47,7 +48,7 @@ export function TerminalPaneAppearanceSection({
'Dim unfocused panes.'
)}
value={paneStyleOptions.inactivePaneOpacity}
defaultValue={0.8}
defaultValue={DEFAULT_TERMINAL_INACTIVE_PANE_OPACITY}
min={0}
max={1}
step={0.05}
+7
View File
@@ -1,5 +1,6 @@
import { describe, expect, it } from 'vitest'
import {
DEFAULT_TERMINAL_INACTIVE_PANE_OPACITY,
getDefaultNotificationSettings,
getDefaultPrimarySelectionMiddleClickPaste,
getDefaultTerminalRightClickToPaste,
@@ -45,6 +46,12 @@ describe('getDefaultSettings', () => {
expect(getDefaultSettings('/tmp').terminalUseSeparateLightTheme).toBe(true)
})
it('keeps inactive terminal panes readable by default', () => {
expect(getDefaultSettings('/tmp').terminalInactivePaneOpacity).toBe(
DEFAULT_TERMINAL_INACTIVE_PANE_OPACITY
)
})
it('asks before closing terminals with running processes by default', () => {
expect(getDefaultSettings('/tmp').skipCloseTerminalWithRunningProcessConfirm).toBe(false)
})
+2 -1
View File
@@ -51,6 +51,7 @@ export const DEFAULT_APP_FONT_FAMILY = 'Geist'
export const DEFAULT_SHOW_SLEEPING_WORKSPACES = true
export const DEFAULT_HIDE_SLEEPING_WORKSPACES = false
export const DEFAULT_AGENT_ACTIVITY_DISPLAY_MODE: AgentActivityDisplayMode = 'compact'
export const DEFAULT_TERMINAL_INACTIVE_PANE_OPACITY = 0.9
export function normalizeAgentActivityDisplayMode(value: unknown): AgentActivityDisplayMode {
return value === 'full' || value === 'compact' ? value : DEFAULT_AGENT_ACTIVITY_DISPLAY_MODE
@@ -223,7 +224,7 @@ export function getDefaultSettings(homedir: string): GlobalSettings {
terminalThemeLight: 'Builtin Tango Light',
terminalCustomThemes: [],
terminalDividerColorLight: '#d4d4d8',
terminalInactivePaneOpacity: 0.8,
terminalInactivePaneOpacity: DEFAULT_TERMINAL_INACTIVE_PANE_OPACITY,
terminalActivePaneOpacity: 1,
terminalPaneOpacityTransitionMs: 140,
terminalDividerThicknessPx: 3,