starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-11-02 10:08:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(e2e): retry the PTY write spy's main-process evaluates on transient CDP failures (#34912)

Browse Source 
The spy already retried its install through retryTransientMainEvaluate, but its
reads, clear and delay setter did not, so a 'Resulting promise was garbage
collected' (playwright#33737) failed a passing Windows WSL paste test.
This commit is contained in:
Neil
2026-10-28 03:06:24 -07:00
committed by GitHub
parent 36d295628e
commit 448ef93938
1 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/helpers/terminal-pty-write-spy.ts
+27 -18
View File
@@ -45,37 +45,46 @@ export async function installTerminalPtyWriteSpy(app: ElectronApplication): Prom
)
}
// Idempotent main-process reads and a clear: safe to repeat after a transient CDP failure.
export async function clearTerminalPtyWriteLog(app: ElectronApplication): Promise<void> {
await app.evaluate(() => {
const global = globalThis as unknown as { __terminalPtyWriteLog?: PtyWriteLogEntry[] }
if (global.__terminalPtyWriteLog) {
global.__terminalPtyWriteLog.length = 0
}
})
await retryTransientMainEvaluate(() =>
app.evaluate(() => {
const global = globalThis as unknown as { __terminalPtyWriteLog?: PtyWriteLogEntry[] }
if (global.__terminalPtyWriteLog) {
global.__terminalPtyWriteLog.length = 0
}
})
)
}
export async function readTerminalPtyWrites(app: ElectronApplication): Promise<string[]> {
return app.evaluate(() => {
const global = globalThis as unknown as { __terminalPtyWriteLog?: PtyWriteLogEntry[] }
return (global.__terminalPtyWriteLog ?? []).map((entry) => entry.data)
})
return retryTransientMainEvaluate(() =>
app.evaluate(() => {
const global = globalThis as unknown as { __terminalPtyWriteLog?: PtyWriteLogEntry[] }
return (global.__terminalPtyWriteLog ?? []).map((entry) => entry.data)
})
)
}
export async function readTerminalPtyWriteEntries(
app: ElectronApplication
): Promise<PtyWriteLogEntry[]> {
return app.evaluate(() => {
const global = globalThis as unknown as { __terminalPtyWriteLog?: PtyWriteLogEntry[] }
return [...(global.__terminalPtyWriteLog ?? [])]
})
return retryTransientMainEvaluate(() =>
app.evaluate(() => {
const global = globalThis as unknown as { __terminalPtyWriteLog?: PtyWriteLogEntry[] }
return [...(global.__terminalPtyWriteLog ?? [])]
})
)
}
export async function setTerminalPtyWriteDelay(
app: Pick<ElectronApplication, 'evaluate'>,
delayMs: number
): Promise<void> {
await app.evaluate((_electron, nextDelayMs) => {
const global = globalThis as unknown as { __terminalPtyWriteDelayMs?: number }
global.__terminalPtyWriteDelayMs = Math.max(0, nextDelayMs)
}, delayMs)
await retryTransientMainEvaluate(() =>
app.evaluate((_electron, nextDelayMs) => {
const global = globalThis as unknown as { __terminalPtyWriteDelayMs?: number }
global.__terminalPtyWriteDelayMs = Math.max(0, nextDelayMs)
}, delayMs)
)
}