test(browser): keep the no-bulk-clear assertion honest after the clearData switch

The mocked session still exposed clearStorageData, so asserting it was never
called could no longer fail once the fast path moved to clearData.
This commit is contained in:
Brennan Benson
2026-08-12 18:57:46 -07:00
parent 54163cd3aa
commit 454d3e975a
@@ -423,7 +423,7 @@ describe('importCookiesFromBrowser Chromium', () => {
let cookiesSetMock: ReturnType<typeof vi.fn>
let cookiesRemoveMock: ReturnType<typeof vi.fn>
let cookiesFlushStoreMock: ReturnType<typeof vi.fn>
let clearStorageDataMock: ReturnType<typeof vi.fn>
let clearDataMock: ReturnType<typeof vi.fn>
let setUserAgentMock: ReturnType<typeof vi.fn>
beforeEach(() => {
@@ -431,7 +431,7 @@ describe('importCookiesFromBrowser Chromium', () => {
cookiesSetMock = vi.fn().mockResolvedValue(undefined)
cookiesRemoveMock = vi.fn().mockResolvedValue(undefined)
cookiesFlushStoreMock = vi.fn().mockResolvedValue(undefined)
clearStorageDataMock = vi.fn().mockResolvedValue(undefined)
clearDataMock = vi.fn().mockResolvedValue(undefined)
setUserAgentMock = vi.fn()
appGetPathMock.mockReset()
appGetPathMock.mockReturnValue(join(tmpDir, 'userData'))
@@ -450,7 +450,7 @@ describe('importCookiesFromBrowser Chromium', () => {
remove: cookiesRemoveMock,
flushStore: cookiesFlushStoreMock
},
clearStorageData: clearStorageDataMock,
clearData: clearDataMock,
setUserAgent: setUserAgentMock
})
})
@@ -511,7 +511,7 @@ describe('importCookiesFromBrowser Chromium', () => {
['', '-wal', '-shm'].map((suffix) => readFileSync(sourceCookiesPath + suffix))
).toEqual(sourceFilesBefore)
expect(cookiesRemoveMock).not.toHaveBeenCalled()
expect(clearStorageDataMock).not.toHaveBeenCalled()
expect(clearDataMock).not.toHaveBeenCalled()
// Why: STA-3514 — imports must never impersonate the source browser; the
// session keeps the engine UA the registry set at startup.
expect(setUserAgentMock).not.toHaveBeenCalled()