starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-24 08:03:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(git-watch): hold reserved inodes across root replacements

Browse Source 
Linux returns a released reservation to the free list, so the second
replacement could land back on the first replacement's inode and look
unchanged to reconciliation. Verified on ext4: releasing yields inodes
[N, N+43, N+43] while holding yields [N, N+43, N+44]. macOS never
recycles, which is why this only failed on CI.
This commit is contained in:
Neil
2026-08-25 00:30:51 -07:00
parent c81876a9d7
commit 4d929e3078
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/ipc/worktree-git-common-watch.test.ts
+8 -4
View File
@@ -45,18 +45,22 @@ const alwaysVisible: WorktreePollerWindowVisibility = {
onWindowBecameVisible: () => () => {}
}
let inodeReservationCount = 0
async function replaceWorktreesRoot(
commonDir: string,
worktreesDir: string,
retainedEntry: string
): Promise<void> {
await rm(worktreesDir, { recursive: true })
// Linux can reuse a just-deleted directory inode. Reserve that inode with a
// sibling before recreating the watched root so reconciliation sees a replacement.
const inodeReservation = join(commonDir, 'worktrees-replacement-inode')
// Linux reuses just-deleted directory inodes. Park each freed inode in a
// sibling that is HELD for the rest of the test — releasing it would return it
// to the free list, so a later replacement could land back on it and look
// unchanged to reconciliation. The dirs are siblings of `worktrees`, which no
// poll or watch path enumerates.
const inodeReservation = join(commonDir, `worktrees-replacement-inode-${++inodeReservationCount}`)
await mkdir(inodeReservation)
await mkdir(retainedEntry, { recursive: true })
await rm(inodeReservation, { recursive: true, force: true })
}
function createVisibilityHarness(): {