starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-27 00:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(ssh): name the root cause the reconnect replay fix does not address

Browse Source 
requireReplay fixes the blank pane at the symptom. The cause is that a PTY
source delivery is the only per-client relay state that outlives its client
detaching: fs-handler, git-handler and relay-filesystem-watch-registry all
subscribe to dispatcher.onClientDetached and release theirs, and
relay-pty-source-publication never does. The primary client keeps its id across
a transport replacement, so its delivery survives a dead transport and
activate() answers 'existing' to a client that cannot receive anything.

Retiring the delivery on detach is the real fix. Not doing it here is a choice,
not an oversight — it is the flow-control and credit path, and I could not
verify it before handing this over. Recorded in the test that guards the
symptom, which is where someone changing this will actually look.
This commit is contained in:
Neil
2026-08-15 02:11:00 -07:00
parent bf88c867ec
commit 506807c87a
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/ssh-docker-reconnect-pane-restore.spec.ts
+11
View File
@@ -32,6 +32,17 @@ const RUN_DOCKER_SSH = process.env.ORCA_E2E_SSH_DOCKER === '1'
*
* Reading the pane's own text is the point. Asserting a pty id, a status, or a spy call is what let
* both of these through: every one of those was correct while the screen was wrong.
*
* KNOWN: (1) is fixed at the symptom, not the cause. The cause is that a PTY source delivery is the
* only per-client relay state that survives its client detaching — fs-handler, git-handler and
* relay-filesystem-watch-registry all subscribe to dispatcher.onClientDetached and release theirs;
* relay-pty-source-publication never does. The primary client keeps its id across a transport
* replacement (detachClient refuses to detach it, setWrite revives that id), so its delivery
* outlives the dead transport and activate() answers 'existing' for a client that can no longer
* receive anything. requireReplay makes the client ask for what the relay wrongly decided it did
* not need. Retiring the delivery on detach is the real fix and is deliberately NOT done here: it
* is the flow-control and credit path, and it was not worth shipping unverified. This test pins the
* user-visible contract either way, so it should keep passing when that lands.
*/
async function openTerminalTab(page: Page): Promise<void> {
await page.evaluate(async () => {