mirror of
https://github.com/stablyai/orca.git
synced 2026-10-21 00:03:46 +00:00
Route PR mention metadata by repo host
Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
@@ -270,4 +270,4 @@ Done means: reviewers and future agents can understand the vision, implementatio
|
||||
- [x] 2026-06-12: Aligned Automations manual-run disabled states with the backend run-target resolver so saved run contexts now disable Run Now when the project-host setup is missing or not ready, instead of failing after dispatch. Verified with focused automation availability tests, targeted oxlint, full `pnpm run typecheck`, and `git diff --check`.
|
||||
- [x] 2026-06-12: Routed GitHub drawer label/assignee/reviewer metadata reads through the same task source context as issue/PR mutations, including slug-addressed Project view rows and reviewer request/remove actions, so same-repo multi-host drawers do not fall back to the repo owner or focused runtime. Verified with a focused source-boundary test, targeted oxlint, full `pnpm run typecheck`, and `git diff --check`.
|
||||
- [x] 2026-06-13: Tightened runtime project-host setup mutations so older remote servers that advertise `project-host-setup.v1` but not `workspace-run-context.v1` are blocked before setup/clone/create/update/delete RPCs mutate server state; read-only hydration still degrades to repo-derived compatibility rows. Verified with focused repo capability tests, targeted oxlint, full `pnpm run typecheck`, and `git diff --check`.
|
||||
- [x] 2026-06-13: Routed the full-page Pull Request metadata popovers through the PR repo owner host instead of ambient focused runtime state, so reviewer, label, and assignee reads align with the existing repo-owned mutation routing. Verified with a focused PR host-boundary test, targeted oxlint, full `pnpm run typecheck`, and `git diff --check`.
|
||||
- [x] 2026-06-13: Routed the full-page Pull Request metadata popovers and mention suggestions through the PR repo owner host instead of ambient focused runtime state, so reviewer, label, assignee, and comment-composer reads align with the existing repo-owned mutation routing. Verified with a focused PR host-boundary test, targeted oxlint, full `pnpm run typecheck`, and `git diff --check`.
|
||||
|
||||
@@ -2682,6 +2682,7 @@ function CommentCodeContext({
|
||||
function ConversationTab({
|
||||
item,
|
||||
repoPath,
|
||||
repoId,
|
||||
body,
|
||||
comments,
|
||||
files,
|
||||
@@ -2729,7 +2730,10 @@ function ConversationTab({
|
||||
const [bodySaving, setBodySaving] = useState(false)
|
||||
const bodyTextareaRef = useRef<HTMLTextAreaElement>(null)
|
||||
const bodyTextareaFocusFrameRef = useRef<number | null>(null)
|
||||
const repoAssignees = useRepoAssignees(repoPath, item.repoId)
|
||||
const repoOwnerSettings = useAppStore(
|
||||
useShallow((s) => getSettingsForRepoRuntimeOwner(s, item.repoId ?? repoId ?? null))
|
||||
)
|
||||
const repoAssignees = useRepoAssignees(repoPath, item.repoId, repoOwnerSettings)
|
||||
const commentCounts = useMemo(() => getPRCommentAudienceCounts(comments), [comments])
|
||||
const visibleComments = useMemo(
|
||||
() => filterPRCommentsByAudience(comments, commentFilter),
|
||||
|
||||
@@ -40,4 +40,12 @@ describe('PullRequestPage host boundaries', () => {
|
||||
expect(section).toContain('useRepoAssigneesBySlug(')
|
||||
expect(section).toContain('repoOwnerSettings')
|
||||
})
|
||||
|
||||
it('routes PR mention metadata through the PR repo owner host', () => {
|
||||
const source = componentSource('PullRequestPage.tsx')
|
||||
const section = sourceBetween(source, 'function ConversationTab', 'const mentionOptions')
|
||||
|
||||
expect(section).toContain('getSettingsForRepoRuntimeOwner(s, item.repoId ?? repoId ?? null)')
|
||||
expect(section).toContain('useRepoAssignees(repoPath, item.repoId, repoOwnerSettings)')
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user