starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-19 08:03:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(github): enforce origin preference in review head origin resolution

Browse Source 
The explicit origin preference must short-circuit before any identity probe, so no remote queries should occur. Add validation to reject unexpected remotes and tighten the test assertion to verify no remote get-url calls happen at all.
This commit is contained in:
Jinjing
2026-07-25 22:32:09 -07:00
parent 6b3ef27d4d
commit 5e22697608
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/runtime/orca-runtime.test.ts
+9 -1
View File
@@ -34598,6 +34598,9 @@ describe('OrcaRuntimeService', () => {
return { stdout: 'origin\n', stderr: '' }
}
if (args[0] === 'remote' && args[1] === 'get-url') {
if (args[2] !== 'origin' && args[2] !== 'upstream') {
throw new Error(`unexpected remote: ${String(args[2])}`)
}
const url =
args[2] === 'origin'
? 'git@github.com:org/repo.git'
@@ -34645,7 +34648,12 @@ describe('OrcaRuntimeService', () => {
cwd: TEST_REPO_PATH,
wslDistro: 'Ubuntu'
})
expect(gitSpy).not.toHaveBeenCalledWith(['remote', 'get-url', 'upstream'], expect.anything())
// Why: the explicit origin preference must short-circuit before any
// identity probe, so no remote — not just upstream — gets a get-url.
expect(gitSpy).not.toHaveBeenCalledWith(
['remote', 'get-url', expect.anything()],
expect.anything()
)
} finally {
gitSpy.mockRestore()
}