fix: address review findings (#2143)

src/main/codex-accounts/runtime-home-service.test.ts

@@ -74,7 +74,7 @@ function createSettings(overrides: Partial<GlobalSettings> = {}): GlobalSettings
     floatingTerminalCwd: '~',
     floatingTerminalTriggerLocation: 'floating-button',
     diffDefaultView: 'inline',
-    combinedDiffFileTreeVisibleByDefault: true,
+    combinedDiffFileTreeVisibleByDefault: false,
     notifications: {
       enabled: true,
       agentTaskComplete: true,

src/main/codex-accounts/service.test.ts

@@ -67,7 +67,7 @@ function createSettings(overrides: Partial<GlobalSettings> = {}): GlobalSettings
     floatingTerminalCwd: '~',
     floatingTerminalTriggerLocation: 'floating-button',
     diffDefaultView: 'inline',
-    combinedDiffFileTreeVisibleByDefault: true,
+    combinedDiffFileTreeVisibleByDefault: false,
     notifications: {
       enabled: true,
       agentTaskComplete: true,

src/main/persistence.test.ts

@@ -596,7 +596,7 @@ describe('Store', () => {
     expect(store.getSettings().refreshLocalBaseRefOnWorktreeCreate).toBe(false)
     expect(store.getSettings().rightSidebarOpenByDefault).toBe(true)
     expect(store.getSettings().showTasksButton).toBe(true)
-    expect(store.getSettings().combinedDiffFileTreeVisibleByDefault).toBe(true)
+    expect(store.getSettings().combinedDiffFileTreeVisibleByDefault).toBe(false)
     expect(store.getSettings().visibleTaskProviders).toEqual(['github', 'gitlab', 'linear'])
     expect(store.getSettings().experimentalActivity).toBe(true)
     expect(store.getSettings().notifications.customSoundPath).toBeNull()

src/renderer/src/components/editor/CombinedDiffViewer.tsx

@@ -121,7 +121,9 @@ function getInitialCombinedDiffSideBySide(diffDefaultView: string | undefined):
 function getInitialCombinedDiffFileTreeCollapsed(
   combinedDiffFileTreeVisibleByDefault: boolean | undefined
 ): boolean {
-  return combinedDiffFileTreeCollapsedPreference ?? combinedDiffFileTreeVisibleByDefault === false
+  // Why: the tree is opt-in for new sessions; only an explicit saved setting
+  // should make it the opening surface while settings are still loading.
+  return combinedDiffFileTreeCollapsedPreference ?? combinedDiffFileTreeVisibleByDefault !== true
 }
 
 function commitMessageBody(message: string | undefined, subject: string | undefined): string {

src/shared/constants.ts

@@ -222,7 +222,7 @@ export function getDefaultSettings(homedir: string): GlobalSettings {
     floatingTerminalTriggerLocation: 'floating-button',
     notifications: getDefaultNotificationSettings(),
     diffDefaultView: 'inline',
-    combinedDiffFileTreeVisibleByDefault: true,
+    combinedDiffFileTreeVisibleByDefault: false,
     promptCacheTimerEnabled: false,
     promptCacheTtlMs: 300_000,
     codexManagedAccounts: [],