starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-21 00:03:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(e2e): negotiate kitty via PTY output in the Ctrl+Enter spec

Browse Source 
The Ctrl+Enter gate reads the PTY-output kitty tracker, which
enableKittyKeyboardReporting never feeds (it writes straight into
xterm's parser), so the spec pressed the chord on a pane the policy
still saw as un-negotiated and got the CR fallback. Negotiate from the
application side like the neighbouring Shift+Enter spec, and reset the
flags afterwards for the serial suite.

Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Neil
2026-08-06 19:01:05 -07:00
committed by OrcaWin
co-authored by Orca
parent 4ae8e80d12
commit 699d4cbd49
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/terminal-shortcuts.spec.ts
+15 -2
View File
@@ -531,13 +531,26 @@ test.describe('Terminal Shortcuts', () => {
electronApp
}) => {
await installMainProcessPtyWriteSpy(electronApp)
await waitForActivePanePtyId(orcaPage)
const ptyId = await waitForActivePanePtyId(orcaPage)
// Why: a plain shell never negotiates kitty, so CSI-u would print verbatim (#12329).
await pressAndExpectWrite(orcaPage, electronApp, 'Control+Enter', '\r')
if (process.platform === 'win32') {
return
}
await enableKittyKeyboardReporting(orcaPage, 31)
// Why: the gate reads the PTY-output tracker, not xterm's renderer-local flags,
// so negotiation has to come from the application side like a real TUI's.
await execInTerminal(orcaPage, ptyId, "printf '\\033[>1u'")
await expect.poll(() => getKittyKeyboardFlags(orcaPage)).toBe(1)
await pressAndExpectWrite(orcaPage, electronApp, 'Control+Enter', '\x1b[13;5u')
// Clear the shell's unconsumed CSI-u line before resetting flags in a settled
// command; otherwise its line editor can swallow the reset bytes.
await sendToTerminal(orcaPage, ptyId, '\x15\x03')
await execInTerminal(orcaPage, ptyId, "printf '\\033[=0u'")
await expect.poll(() => getKittyKeyboardFlags(orcaPage)).toBe(0)
await pressAndExpectWrite(orcaPage, electronApp, 'Control+Enter', '\r')
})
test('plain Ctrl+C sends ETX under kitty keyboard reporting', async ({