test(renderer): cover repo catalog refresh identity

A dedicated file — repos.test.ts is already at the max-lines ceiling and these are a distinct concern. The fixture is production-shaped on purpose. A scalar-only repo reconciles even when the structural compare is broken, which is how an earlier version of this work shipped green while being completely inert; addedAt is pinned non-zero because project-host-setup-projection falls back to `repo.addedAt || now`, so a zero timestamp stamps Date.now() into every projection and nothing ever reconciles. Every mocked fetch returns a structuredClone so identity can never match by accident. Every identity assertion was verified red against reverted source: - drop reconcileCatalogRows from the merge return -> no-op-refetch identity and per-element reuse fail - filterSetupsForPrunedRepoRows back to `[...setups]` -> no-op-refetch identity fails - retainValidFilterRepoIds back to `.filter(...)` -> both filter-identity cases fail - areValuesEqual reduced to `a === b` -> all three reconcile cases fail - areValuesEqual forced to `true` -> all six change-propagation cases fail - setup key switched to setup.id -> the two-hosts-one-repo-id case fails Co-authored-by: Orca <help@stably.ai>
2026-10-22 00:03:47 +00:00 · 2026-08-12 19:47:59 -07:00
parent 6c3c2b612d
commit 6a6682fa91
1 changed files with 283 additions and 0 deletions
@@ -0,0 +1,283 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+import type { Project, Repo } from '../../../../shared/types'
+import { createTestStore } from './store-test-helpers'
+
+// Why: every field here is load-bearing. A scalar-only repo reconciles even when the structural
+// compare is broken, which is exactly how an earlier version of this work shipped green and inert.
+// addedAt must stay non-zero: project-host-setup-projection falls back to `repo.addedAt || now`,
+// so a zero timestamp stamps Date.now() into every projection and nothing ever reconciles.
+const repo: Repo = {
+  id: 'repo-1',
+  path: '/repo-1',
+  displayName: 'Repo 1',
+  badgeColor: '#000000',
+  addedAt: 1_700_000_000_000,
+  executionHostId: 'local',
+  kind: 'git',
+  repoIcon: { type: 'lucide', name: 'Box' },
+  upstream: { owner: 'upstream-owner', repo: 'repo-1', host: 'github.com' },
+  gitRemoteIdentity: {
+    canonicalKey: 'github.com/octocat/repo-1',
+    remoteName: 'origin',
+    remoteUrl: 'git@github.com:octocat/repo-1.git'
+  },
+  hookSettings: { mode: 'auto', scripts: { setup: 'echo hi', archive: '' } },
+  symlinkPaths: ['.env', 'node_modules'],
+  importedExternalWorktreePaths: []
+}
+
+const secondRepo: Repo = {
+  ...repo,
+  id: 'repo-2',
+  path: '/repo-2',
+  displayName: 'Repo 2',
+  addedAt: 1_700_000_001_000,
+  upstream: { owner: 'upstream-owner', repo: 'repo-2', host: 'github.com' },
+  gitRemoteIdentity: {
+    canonicalKey: 'github.com/octocat/repo-2',
+    remoteName: 'origin',
+    remoteUrl: 'git@github.com:octocat/repo-2.git'
+  }
+}
+
+const reposList = vi.fn()
+const projectsList = vi.fn()
+const listHostSetups = vi.fn()
+
+// Why: catalogs arrive over IPC, so every fetch must hand back freshly allocated objects —
+// otherwise identity would match by accident and prove nothing.
+function clone<T>(value: T): T {
+  return structuredClone(value)
+}
+
+function mockRepos(...rows: readonly Repo[]): void {
+  reposList.mockImplementation(async () => rows.map(clone))
+}
+
+beforeEach(() => {
+  reposList.mockReset()
+  projectsList.mockReset()
+  listHostSetups.mockReset()
+  mockRepos(repo)
+  projectsList.mockImplementation(async () => [])
+  listHostSetups.mockImplementation(async () => [])
+
+  vi.stubGlobal('window', {
+    api: {
+      repos: { list: reposList },
+      projects: { list: projectsList, listHostSetups }
+    },
+    dispatchEvent: vi.fn()
+  })
+})
+
+describe('repo catalog refresh identity', () => {
+  it('keeps the projects and host setups arrays and entries across a no-op refetch', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const projects = store.getState().projects
+    const setups = store.getState().projectHostSetups
+    expect(projects).toHaveLength(1)
+    expect(setups).toHaveLength(1)
+
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projects).toBe(projects)
+    expect(store.getState().projects[0]).toBe(projects[0])
+    expect(store.getState().projectHostSetups).toBe(setups)
+    expect(store.getState().projectHostSetups[0]).toBe(setups[0])
+  })
+
+  it('lets a nested hookSettings change through', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const setups = store.getState().projectHostSetups
+
+    mockRepos({ ...repo, hookSettings: { mode: 'override', scripts: { setup: '', archive: '' } } })
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projectHostSetups).not.toBe(setups)
+    expect(store.getState().projectHostSetups[0]?.hookSettings?.mode).toBe('override')
+  })
+
+  it('lets a displayName change through on projects', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const projects = store.getState().projects
+
+    mockRepos({ ...repo, displayName: 'Renamed' })
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projects).not.toBe(projects)
+    expect(store.getState().projects[0]?.displayName).toBe('Renamed')
+  })
+
+  it('lets an array-field change through', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const repos = store.getState().repos
+
+    mockRepos({ ...repo, symlinkPaths: ['.env'] })
+    await store.getState().fetchRepos()
+
+    expect(store.getState().repos).not.toBe(repos)
+    expect(store.getState().repos[0]?.symlinkPaths).toEqual(['.env'])
+  })
+
+  it('lets a nested gitRemoteIdentity change through', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const projects = store.getState().projects
+
+    mockRepos({
+      ...repo,
+      gitRemoteIdentity: { ...repo.gitRemoteIdentity!, remoteName: 'upstream' }
+    })
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projects).not.toBe(projects)
+    expect(store.getState().projects[0]?.gitRemoteIdentity?.remoteName).toBe('upstream')
+  })
+
+  it('treats clearing localWindowsRuntimePreference as a change', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const projectId = store.getState().projects[0]!.id
+    const withPreference: Project = {
+      ...store.getState().projects[0]!,
+      localWindowsRuntimePreference: { kind: 'wsl', distro: 'Ubuntu' }
+    }
+    store.setState({ projects: [withPreference] })
+
+    await store.getState().fetchRepos()
+
+    // Why: a local-host refresh is authoritative; an absent key must not read as unchanged.
+    expect(store.getState().projects[0]).not.toBe(withPreference)
+    expect(store.getState().projects[0]?.id).toBe(projectId)
+    expect(store.getState().projects[0]?.localWindowsRuntimePreference).toBeUndefined()
+  })
+
+  it('reuses an unchanged setup element while a sibling changes', async () => {
+    mockRepos(repo, secondRepo)
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const setups = store.getState().projectHostSetups
+    expect(setups).toHaveLength(2)
+
+    mockRepos(repo, { ...secondRepo, displayName: 'Repo 2 renamed' })
+    await store.getState().fetchRepos()
+
+    const next = store.getState().projectHostSetups
+    expect(next).not.toBe(setups)
+    expect(next[0]).toBe(setups[0])
+    expect(next[1]).not.toBe(setups[1])
+  })
+
+  it('does not reuse a setup that moved to a different execution host', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const setups = store.getState().projectHostSetups
+    expect(setups[0]?.hostId).toBe('local')
+
+    // Why: the repo-derived fallback sets setup.id = repo.id, so the same id on a second host is
+    // the case that would silently splice the wrong host's routing metadata into the row.
+    mockRepos({ ...repo, executionHostId: 'ssh:host-a', connectionId: 'host-a' })
+    await store.getState().fetchRepos()
+
+    const next = store.getState().projectHostSetups
+    expect(next[0]).not.toBe(setups[0])
+    expect(next[0]?.hostId).toBe('ssh:host-a')
+  })
+
+  it('reconciles both setups when one repo id exists on two hosts', async () => {
+    // Why: the repo-derived fallback sets setup.id = repo.id, so these two setups share an id and
+    // differ only by host. Keying the reconcile on setup.id instead of the owner key collapses them
+    // onto one slot and one of the two churns on every refresh.
+    const sshRepo: Repo = { ...repo, executionHostId: 'ssh:host-a', connectionId: 'host-a' }
+    mockRepos(repo, sshRepo)
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const setups = store.getState().projectHostSetups
+    expect(setups).toHaveLength(2)
+    expect(new Set(setups.map((setup) => setup.id)).size).toBe(1)
+
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projectHostSetups).toBe(setups)
+    expect(store.getState().projectHostSetups[0]).toBe(setups[0])
+    expect(store.getState().projectHostSetups[1]).toBe(setups[1])
+  })
+
+  it('drops a project and its setup when its repo disappears', async () => {
+    mockRepos(repo, secondRepo)
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const projects = store.getState().projects
+
+    mockRepos(repo)
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projects).not.toBe(projects)
+    expect(store.getState().projects).toHaveLength(1)
+    expect(store.getState().projectHostSetups).toHaveLength(1)
+  })
+
+  it('adds a project and its setup when a repo appears', async () => {
+    const store = createTestStore()
+    await store.getState().fetchRepos()
+    const projects = store.getState().projects
+
+    mockRepos(repo, secondRepo)
+    await store.getState().fetchRepos()
+
+    expect(store.getState().projects).not.toBe(projects)
+    expect(store.getState().projects).toHaveLength(2)
+    expect(store.getState().projectHostSetups).toHaveLength(2)
+  })
+})
+
+describe('repo filter identity across catalog refreshes', () => {
+  it('keeps the filterRepoIds array when a refetch prunes nothing', async () => {
+    const store = createTestStore()
+    store.setState({ filterRepoIds: [repo.id] })
+    const first = store.getState().filterRepoIds
+
+    await store.getState().fetchRepos()
+
+    // Why: App.tsx at the root and five sidebar consumers select this array by identity.
+    expect(store.getState().filterRepoIds).toBe(first)
+  })
+
+  it('still prunes a filtered repo id that no longer exists', async () => {
+    const store = createTestStore()
+    store.setState({ filterRepoIds: [repo.id, 'gone'] })
+
+    await store.getState().fetchRepos()
+
+    expect(store.getState().filterRepoIds).toEqual([repo.id])
+  })
+
+  it('prunes only the vanished id and reallocates', async () => {
+    mockRepos(repo)
+    const store = createTestStore()
+    store.setState({ filterRepoIds: [repo.id, secondRepo.id] })
+    const first = store.getState().filterRepoIds
+
+    await store.getState().fetchRepos()
+
+    expect(store.getState().filterRepoIds).toEqual([repo.id])
+    expect(store.getState().filterRepoIds).not.toBe(first)
+  })
+
+  it('keeps a filtered id whose repo merely moved to another host', async () => {
+    const store = createTestStore()
+    store.setState({ filterRepoIds: [repo.id] })
+    const first = store.getState().filterRepoIds
+
+    // Why: the filter is keyed on repo id, not host identity — a rehomed repo is not pruned.
+    mockRepos({ ...repo, executionHostId: 'ssh:host-a', connectionId: 'host-a' })
+    await store.getState().fetchRepos()
+
+    expect(store.getState().filterRepoIds).toBe(first)
+  })
+})