starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-27 00:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(mobile-web): split the closure-frame ledger table instead of branching in tests

Browse Source 
oxlint vitest(no-conditional-tests) failed the focused code-quality plugin job on the if that skipped the invalid-message case for the browser ledger. Derive a RETIRING_LEDGER_CASES table and drive both cases with it.each so no test body branches.

Claude-Session: https://claude.ai/code/session_01JNnE9qzUZMMnqpZWCqM3nb
This commit is contained in:
Jinwoo-H
2026-09-04 18:55:34 -04:00
parent 5359ddff97
commit 6be9dc43e1
1 changed files with 24 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mobile/src/mobile-web/mobile-web-subscription-closure-frames.test.ts
+24 -19
View File
@@ -213,27 +213,32 @@ const LEDGER_CASES: LedgerCase[] = [
}
]
// Ledgers that retire on an unusable host message; browser drops the frame instead, so it is absent.
const RETIRING_LEDGER_CASES = LEDGER_CASES.filter(
(ledger): ledger is LedgerCase & { invalidCode: 'invalid_message' } => ledger.invalidCode !== null
)
// Without a terminal frame the page keeps a live subscription and freezes on its last value.
describe('shell subscription ledgers publish a closure frame when they retire early', () => {
for (const ledger of LEDGER_CASES) {
if (ledger.invalidCode) {
it(`closes the ${ledger.name} subscription on an unusable host message`, async () => {
const closures: [string, MobileWebSubscriptionClosure][] = []
const emit = await ledger.open({
isActive: () => true,
postEvent: async () => {},
postClosed: (subscriptionId, closure) => closures.push([subscriptionId, closure])
})
emit(ledger.invalid)
expect(closures).toEqual([
[SUBSCRIPTION_ID, { code: ledger.invalidCode, retryable: false }]
])
it.each(RETIRING_LEDGER_CASES)(
'closes the $name subscription on an unusable host message',
async (ledger) => {
const closures: [string, MobileWebSubscriptionClosure][] = []
const emit = await ledger.open({
isActive: () => true,
postEvent: async () => {},
postClosed: (subscriptionId, closure) => closures.push([subscriptionId, closure])
})
}
it(`closes the ${ledger.name} subscription when the page post fails`, async () => {
emit(ledger.invalid)
expect(closures).toEqual([[SUBSCRIPTION_ID, { code: ledger.invalidCode, retryable: false }]])
}
)
it.each(LEDGER_CASES)(
'closes the $name subscription when the page post fails',
async (ledger) => {
const closures: [string, MobileWebSubscriptionClosure][] = []
const emit = await ledger.open({
isActive: () => true,
@@ -247,6 +252,6 @@ describe('shell subscription ledgers publish a closure frame when they retire ea
await vi.waitFor(() => expect(closures).toHaveLength(1))
expect(closures[0]).toEqual([SUBSCRIPTION_ID, { code: 'unavailable', retryable: true }])
})
}
}
)
})