mirror of
https://github.com/stablyai/orca.git
synced 2026-11-19 04:13:57 +00:00
Show tab previews only when titles are clipped (#37085)
This commit is contained in:
@@ -0,0 +1,64 @@
|
||||
import { Terminal } from 'lucide-react'
|
||||
import { defineFixture } from '../../component-fixtures/component-fixture'
|
||||
import { TabHoverCard } from './TabHoverCard'
|
||||
import { TabStripTooltipProvider } from './TabStripTooltipProvider'
|
||||
import { TAB_LABEL_WIDTH_CLASSES } from './tab-width-rules'
|
||||
|
||||
function preview(width: number): React.JSX.Element {
|
||||
return (
|
||||
<div className="h-48 p-4">
|
||||
<TabStripTooltipProvider>
|
||||
<TabHoverCard title="Codex Chat" programName="Codex" icon={<Terminal className="size-4" />}>
|
||||
<div
|
||||
tabIndex={0}
|
||||
style={{ width }}
|
||||
className="flex h-8 items-center gap-1 border border-border bg-background px-2 text-xs text-foreground"
|
||||
>
|
||||
<Terminal className="size-3 shrink-0" />
|
||||
<span className={TAB_LABEL_WIDTH_CLASSES}>Codex Chat</span>
|
||||
</div>
|
||||
</TabHoverCard>
|
||||
</TabStripTooltipProvider>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
|
||||
export const fullTitle = defineFixture({
|
||||
width: 400,
|
||||
render: () => preview(300),
|
||||
interact: (frame) => {
|
||||
frame.querySelector<HTMLElement>('[tabindex]')?.focus()
|
||||
if (document.querySelector('[data-tab-hover-card]')) {
|
||||
throw new Error('Full title should not open a preview')
|
||||
}
|
||||
}
|
||||
})
|
||||
|
||||
export const clippedTitle = defineFixture({
|
||||
width: 400,
|
||||
render: () => preview(80),
|
||||
interact: (frame) => {
|
||||
frame.querySelector<HTMLElement>('[tabindex]')?.focus()
|
||||
}
|
||||
})
|
||||
|
||||
export const widenedTitle = defineFixture({
|
||||
width: 400,
|
||||
render: () => preview(80),
|
||||
interact: async (frame) => {
|
||||
const tab = frame.querySelector<HTMLElement>('[tabindex]')
|
||||
tab?.focus()
|
||||
await new Promise(requestAnimationFrame)
|
||||
if (!document.querySelector('[data-tab-hover-card]')) {
|
||||
throw new Error('Clipped title should open a preview')
|
||||
}
|
||||
if (tab) {
|
||||
tab.style.width = '300px'
|
||||
}
|
||||
await new Promise(requestAnimationFrame)
|
||||
await new Promise(requestAnimationFrame)
|
||||
if (document.querySelector('[data-tab-hover-card]')) {
|
||||
throw new Error('Widening the tab should close its preview')
|
||||
}
|
||||
}
|
||||
})
|
||||
@@ -1,4 +1,4 @@
|
||||
import { useState, type ReactNode, type SyntheticEvent } from 'react'
|
||||
import { useEffect, useRef, useState, type ReactNode, type SyntheticEvent } from 'react'
|
||||
import { flushSync } from 'react-dom'
|
||||
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip'
|
||||
|
||||
@@ -19,12 +19,42 @@ export function TabHoverCard({
|
||||
alert?: ReactNode | ((dismiss: () => void) => ReactNode)
|
||||
}): React.JSX.Element {
|
||||
const [open, setOpen] = useState(false)
|
||||
const triggerRef = useRef<HTMLElement>(null)
|
||||
// Remove the portal before navigation can start rendering a slower destination.
|
||||
const dismiss = () => flushSync(() => setOpen(false))
|
||||
const interactive = alert !== undefined && alert !== null
|
||||
const canOpen = (): boolean => {
|
||||
const label = triggerRef.current?.querySelector<HTMLElement>('.tab-label')
|
||||
return interactive || !!(label && label.scrollWidth > label.clientWidth)
|
||||
}
|
||||
|
||||
useEffect(() => {
|
||||
if (!open || interactive) {
|
||||
return
|
||||
}
|
||||
const label = triggerRef.current?.querySelector<HTMLElement>('.tab-label')
|
||||
if (!label) {
|
||||
return
|
||||
}
|
||||
const observer = new ResizeObserver(() => {
|
||||
if (label.scrollWidth <= label.clientWidth) {
|
||||
setOpen(false)
|
||||
}
|
||||
})
|
||||
observer.observe(label)
|
||||
return () => observer.disconnect()
|
||||
}, [open, interactive, title])
|
||||
|
||||
return (
|
||||
<Tooltip open={open} onOpenChange={setOpen} disableHoverableContent={!interactive}>
|
||||
<Tooltip
|
||||
open={open}
|
||||
onOpenChange={(nextOpen) => setOpen(nextOpen && canOpen())}
|
||||
disableHoverableContent={!interactive}
|
||||
>
|
||||
<TooltipTrigger
|
||||
ref={(node) => {
|
||||
triggerRef.current = node
|
||||
}}
|
||||
asChild
|
||||
onFocus={(event) => {
|
||||
// Nested controls own their focus hints.
|
||||
|
||||
@@ -10,10 +10,14 @@ function renderTabs(): void {
|
||||
<StrictMode>
|
||||
<TabStripTooltipProvider>
|
||||
<TabHoverCard title="Build" icon={<span />} programName="Terminal">
|
||||
<button>first tab</button>
|
||||
<button>
|
||||
<span className="tab-label">first tab</span>
|
||||
</button>
|
||||
</TabHoverCard>
|
||||
<TabHoverCard title="Codex Chat" icon={<span />} programName="Codex">
|
||||
<button>second tab</button>
|
||||
<button>
|
||||
<span className="tab-label">second tab</span>
|
||||
</button>
|
||||
</TabHoverCard>
|
||||
</TabStripTooltipProvider>
|
||||
</StrictMode>
|
||||
@@ -32,6 +36,12 @@ describe('TabStripTooltipProvider', () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers()
|
||||
renderTabs()
|
||||
for (const label of document.querySelectorAll('.tab-label')) {
|
||||
Object.defineProperties(label, {
|
||||
clientWidth: { configurable: true, value: 60 },
|
||||
scrollWidth: { configurable: true, value: 100 }
|
||||
})
|
||||
}
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
@@ -39,6 +49,28 @@ describe('TabStripTooltipProvider', () => {
|
||||
vi.useRealTimers()
|
||||
})
|
||||
|
||||
it('keeps previews hidden when the full title fits, including keyboard focus', () => {
|
||||
Object.defineProperty(screen.getByText('first tab'), 'clientWidth', { value: 100 })
|
||||
hover('first tab')
|
||||
advance(TAB_TOOLTIP_DELAY_MS)
|
||||
expect(screen.queryByText('Build')).toBeNull()
|
||||
act(() => screen.getByRole('button', { name: 'first tab' }).focus())
|
||||
expect(screen.queryByText('Build')).toBeNull()
|
||||
})
|
||||
|
||||
it('remeasures the title when a tab shrinks before the next hover', () => {
|
||||
const label = screen.getByText('first tab')
|
||||
Object.defineProperty(label, 'clientWidth', { configurable: true, value: 120 })
|
||||
hover('first tab')
|
||||
advance(TAB_TOOLTIP_DELAY_MS)
|
||||
expect(screen.queryByText('Build')).toBeNull()
|
||||
fireEvent.pointerLeave(screen.getByRole('button', { name: 'first tab' }))
|
||||
Object.defineProperty(label, 'clientWidth', { value: 60 })
|
||||
hover('first tab')
|
||||
advance(TAB_TOOLTIP_DELAY_MS)
|
||||
expect(screen.getAllByText('Build').length).toBeGreaterThan(0)
|
||||
})
|
||||
|
||||
it('holds the first preview until a 500 ms hover', () => {
|
||||
hover('first tab')
|
||||
advance(499)
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
// Divide available space independently of titles; overflow only at the readable minimum.
|
||||
export const TAB_CONTAINER_WIDTH_CLASSES = 'min-w-[144px] flex-1'
|
||||
|
||||
export const TAB_LABEL_WIDTH_CLASSES = 'min-w-0 flex-1 truncate'
|
||||
export const TAB_LABEL_WIDTH_CLASSES = 'tab-label min-w-0 flex-1 truncate'
|
||||
|
||||
Reference in New Issue
Block a user