Only open terminal when pre-install checks succeed

Prevent the terminal from opening and setting the terminal command if onBeforeOpenTerminal or refreshPreInstallNotice throws an error.
2026-10-28 16:02:55 +00:00 · 2026-06-27 01:47:10 -07:00
parent 576d6c1d57
commit 792eb288c3
1 changed files with 8 additions and 2 deletions
@@ -173,14 +173,20 @@ export function AgentSkillSetupPanel({
            const nextCommand = activeCommand
            setTerminalOpening(true)
            void (async () => {
+              let shouldOpenTerminal = false
              try {
                await onBeforeOpenTerminal?.()
                await refreshPreInstallNotice()
+                shouldOpenTerminal = true
+              } catch {
+                shouldOpenTerminal = false
              } finally {
                if (mountedRef.current) {
                  setTerminalOpening(false)
-                  setTerminalCommand(nextCommand)
-                  setTerminalOpen(true)
+                  if (shouldOpenTerminal) {
+                    setTerminalCommand(nextCommand)
+                    setTerminalOpen(true)
+                  }
                }
              }
            })()