starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-24 00:02:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix floating workspace open warnings

Browse Source 
Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Jinwoo-H
2026-05-31 04:08:16 -07:00
committed by Neil
co-authored by Orca
parent 80f1d19e0b
commit 81baea8ebb
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/App.tsx
+12 -11
View File
@@ -413,18 +413,19 @@ function App(): React.JSX.Element {
const setFloatingTerminalOpenWithFocus = useCallback(
(nextOpen: SetStateAction<boolean>): void => {
setFloatingTerminalOpen((currentOpen) => {
const resolvedOpen = typeof nextOpen === 'function' ? nextOpen(currentOpen) : nextOpen
if (resolvedOpen && !currentOpen) {
useAppStore.getState().recordFeatureInteraction('floating-workspace')
rememberFloatingTerminalReturnFocus()
} else if (!resolvedOpen && currentOpen) {
restoreFloatingTerminalReturnFocus()
}
return resolvedOpen
})
const resolvedOpen =
typeof nextOpen === 'function' ? nextOpen(floatingTerminalOpen) : nextOpen
// Why: recordFeatureInteraction updates Zustand subscribers; doing it
// inside React's state updater logs a render-phase update warning.
if (resolvedOpen && !floatingTerminalOpen) {
useAppStore.getState().recordFeatureInteraction('floating-workspace')
rememberFloatingTerminalReturnFocus()
} else if (!resolvedOpen && floatingTerminalOpen) {
restoreFloatingTerminalReturnFocus()
}
setFloatingTerminalOpen(resolvedOpen)
},
[rememberFloatingTerminalReturnFocus, restoreFloatingTerminalReturnFocus]
[floatingTerminalOpen, rememberFloatingTerminalReturnFocus, restoreFloatingTerminalReturnFocus]
)
useEffect(() => {